2
0
mirror of https://github.com/tenrok/vue-select.git synced 2026-06-13 08:32:26 +03:00

Do not hide input while loading options. (#621)

Adding the `.hidden` class to the input while loading would cause it to
lose padding. This would cause the text to "jump" back and forth.
This commit is contained in:
Steven Harman
2018-09-05 10:23:36 -04:00
committed by Jeff Sagal
parent fb2d24f6df
commit 9262863514
2 changed files with 19 additions and 2 deletions
+1 -1
View File
@@ -1080,7 +1080,7 @@
*/
inputClasses() {
return {
hidden: !this.isValueEmpty && !this.dropdownOpen
hidden: !this.isValueEmpty && !this.dropdownOpen && !this.mutableLoading
}
},
+18 -1
View File
@@ -1603,7 +1603,6 @@ describe('Select.vue', () => {
expect(vm.$children[0].inputClasses.hidden).toEqual(true)
})
it('should not apply the "hidden" class to the search input when a value is present, and the dropdown is open', (done) => {
const vm = new Vue({
template: '<div><v-select ref="select" :options="options" :value="value"></v-select></div>',
@@ -1623,6 +1622,24 @@ describe('Select.vue', () => {
})
})
it('should not apply the "hidden" class to the search input when a value is present, the dropdown is closed, and options are loading', (done) => {
const vm = new Vue({
template: '<div><v-select ref="select" :options="options" :value="value"></v-select></div>',
data: {
value: 'one',
options: ['one', 'two', 'three'],
open: true
}
}).$mount()
vm.$refs.select.toggleLoading(true)
Vue.nextTick(() => {
Vue.nextTick(() => {
expect(vm.$children[0].inputClasses.hidden).toEqual(false)
done()
})
})
})
it ('should not reset the search input on focus lost when clearSearchOnSelect is false', (done) => {
const vm = new Vue({
template: '<div><v-select ref="select" :options="options" :value="value" :clear-search-on-select="false"></v-select></div>',