2
0
mirror of https://github.com/tenrok/axios.git synced 2026-05-15 11:59:42 +03:00

Improving the response API

This commit is contained in:
Matt Zabriskie
2014-08-29 16:09:40 -06:00
parent 1c35eaadc0
commit d441f8392f
11 changed files with 38 additions and 29 deletions
+8 -5
View File
@@ -98,11 +98,14 @@ define("axios", [], function() { return /******/ (function(modules) { // webpack
};
// Resolve or reject the Promise based on the status
if (request.status >= 200 && request.status < 300) {
resolve(response);
} else {
reject(response);
}
(request.status >= 200 && request.status < 300
? resolve
: reject)(
response.data,
response.status,
response.headers,
response.config
);
// Clean up request
request = null;
+1 -1
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
+8 -5
View File
@@ -99,11 +99,14 @@ var axios =
};
// Resolve or reject the Promise based on the status
if (request.status >= 200 && request.status < 300) {
resolve(response);
} else {
reject(response);
}
(request.status >= 200 && request.status < 300
? resolve
: reject)(
response.data,
response.status,
response.headers,
response.config
);
// Clean up request
request = null;
+1 -1
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
+1 -1
View File
File diff suppressed because one or more lines are too long
+4 -4
View File
@@ -58,10 +58,10 @@
<script src="../dist/axios.min.js"></script>
<script>
axios.get('people.json')
.success(function (response) {
.success(function (data) {
var people = [];
response.data.forEach(function (person) {
data.forEach(function (person) {
people.push(
'<li>' +
'<img src="https://avatars.githubusercontent.com/u/' + person.avatar + '?s=50"/>' +
@@ -74,8 +74,8 @@
document.getElementById('people').innerHTML = people.join('');
})
.error(function(response) {
document.getElementById('people').innerHTML = '<li class="error">' + response.data + '</li>';
.error(function(data) {
document.getElementById('people').innerHTML = '<li class="error">' + data + '</li>';
});
</script>
</body>
+8 -5
View File
@@ -46,11 +46,14 @@ var axios = module.exports = function axios(config) {
};
// Resolve or reject the Promise based on the status
if (request.status >= 200 && request.status < 300) {
resolve(response);
} else {
reject(response);
}
(request.status >= 200 && request.status < 300
? resolve
: reject)(
response.data,
response.status,
response.headers,
response.config
);
// Clean up request
request = null;
+4 -4
View File
@@ -131,11 +131,11 @@
request.innerHTML = JSON.stringify(options, null, 2);
axios(options)
.success(function (res) {
response.innerHTML = JSON.stringify(res.data, null, 2);
.success(function (data) {
response.innerHTML = JSON.stringify(data, null, 2);
})
.error(function (res) {
response.innerHTML = JSON.stringify(res.data, null, 2);
.error(function (data) {
response.innerHTML = JSON.stringify(data, null, 2);
});
};