Bob Lail
fcb5e05c07
* ci: Add a test for positional args that are passthrough on a command that isn't passthrough
* fix: When a Grammar combines flags with passthrough args, see if an unrecognized flag may be treated as a positional argument
Given a grammar like this:
```golang
var cli struct {
Args []string `arg:"" optional:"" passthrough:""`
}
```
The first positional argument implies that it was preceded by `--`, so subsequent flags are not parsed.
If Kong parses `cli 1 --unknown 3`, it will populate `Args` with `[]string{"1", "--unknown", "3"}`.
However, if Kong parses `cli --unknown 2 3`, it will fail saying that `--unknown` is an unrecognized flag.
This commit changes the parser so that if an unknown flag _could_ be treated as the first passthrough argument, it is.
After this change, if Kong parses `cli --unknown 2 3`, it will populate `Args` with `[]string{"--unknown", "2", "3"}`.
* ci: Skip the `maintidx` linter for `trace()`
94 lines
2.2 KiB
YAML
94 lines
2.2 KiB
YAML
run:
|
|
tests: true
|
|
|
|
output:
|
|
print-issued-lines: false
|
|
|
|
linters:
|
|
enable-all: true
|
|
disable:
|
|
- maligned
|
|
- lll
|
|
- gochecknoglobals
|
|
- wsl
|
|
- funlen
|
|
- gocognit
|
|
- gomnd
|
|
- goprintffuncname
|
|
- paralleltest
|
|
- nlreturn
|
|
- goerr113
|
|
- ifshort
|
|
- testpackage
|
|
- wrapcheck
|
|
- exhaustivestruct
|
|
- forbidigo
|
|
- gci
|
|
- godot
|
|
- gofumpt
|
|
- cyclop
|
|
- errorlint
|
|
- nestif
|
|
- golint
|
|
- scopelint
|
|
- interfacer
|
|
- tagliatelle
|
|
- thelper
|
|
- godox
|
|
- goconst
|
|
- varnamelen
|
|
- ireturn
|
|
- exhaustruct
|
|
- nonamedreturns
|
|
- nilnil
|
|
- nosnakecase # deprecated since v1.48.1
|
|
- structcheck # deprecated since v1.49.0
|
|
- deadcode # deprecated since v1.49.0
|
|
- varcheck # deprecated since v1.49.0
|
|
- depguard # nothing to guard against yet
|
|
- tagalign # hurts readability of kong tags
|
|
|
|
linters-settings:
|
|
govet:
|
|
check-shadowing: true
|
|
# These govet checks are disabled by default, but they're useful.
|
|
enable:
|
|
- niliness
|
|
- sortslice
|
|
- unusedwrite
|
|
dupl:
|
|
threshold: 100
|
|
gocyclo:
|
|
min-complexity: 20
|
|
exhaustive:
|
|
default-signifies-exhaustive: true
|
|
|
|
issues:
|
|
max-per-linter: 0
|
|
max-same: 0
|
|
exclude-use-default: false
|
|
exclude:
|
|
- '^(G104|G204):'
|
|
# Very commonly not checked.
|
|
- 'Error return value of .(.*\.Help|.*\.MarkFlagRequired|(os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*printf?|os\.(Un)?Setenv). is not checked'
|
|
- 'exported method (.*\.MarshalJSON|.*\.UnmarshalJSON) should have comment or be unexported'
|
|
- 'composite literal uses unkeyed fields'
|
|
- 'bad syntax for struct tag key'
|
|
- 'bad syntax for struct tag pair'
|
|
- 'result .* \(error\) is always nil'
|
|
|
|
exclude-rules:
|
|
# Don't warn on unused parameters.
|
|
# Parameter names are useful for documentation.
|
|
# Replacing them with '_' hides useful information.
|
|
- linters: [revive]
|
|
text: 'unused-parameter: parameter \S+ seems to be unused, consider removing or renaming it as _'
|
|
|
|
# Duplicate words are okay in tests.
|
|
- linters: [dupword]
|
|
path: _test\.go
|
|
|
|
- linters: [maintidx]
|
|
path: context\.go
|
|
text: 'Function name: trace'
|