fix: remove showing app name twice in errors (#368)

This commit is contained in:
Mitar
2023-07-21 05:08:56 -07:00
committed by GitHub
parent a9be85c4d3
commit 074ccd0906
2 changed files with 6 additions and 3 deletions
+5 -2
View File
@@ -201,7 +201,7 @@ func (c *Context) Validate() error { // nolint: gocyclo
case *Application:
value = node.Target
desc = node.Name
desc = ""
case *Node:
value = node.Target
@@ -209,7 +209,10 @@ func (c *Context) Validate() error { // nolint: gocyclo
}
if validate := isValidatable(value); validate != nil {
if err := validate.Validate(); err != nil {
return fmt.Errorf("%s: %w", desc, err)
if desc != "" {
return fmt.Errorf("%s: %w", desc, err)
}
return err
}
}
}
+1 -1
View File
@@ -1214,7 +1214,7 @@ func TestValidateApp(t *testing.T) {
cli := validateCli{}
p := mustNew(t, &cli)
_, err := p.Parse([]string{})
assert.EqualError(t, err, "test: app error")
assert.EqualError(t, err, "app error")
}
func TestValidateCmd(t *testing.T) {