mirrors/vue-select
2
0
Fork 0
mirror of https://github.com/tenrok/vue-select.git synced 2026-05-17 02:29:37 +03:00
Code Activity

Change all keyup events to keydown (#935)

Browse Source 
For a few reasons:

- event.preventDefault() for the Enter key (to stop it from submitting
  the form when you select an item) is only effective if it's a keydown
  event.

- Using keydown for up/down navigation means you can hold them down to
  rapidly scroll through a lot of items.

- Keydown events make the UX feel more responsive, and is consistent
  with how most apps/operating systems handle key presses.
This commit is contained in:
Toby Zerner
2019-10-26 06:42:59 +10:30
committed by Jeff Sagal
parent aea81a6f5c
commit ceb42b4950
4 changed files with 11 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/helpers.js
+1 -1
View File
@@ -13,7 +13,7 @@ export const searchSubmit = (Wrapper, searchText = false) => {
if (searchText) {
Wrapper.vm.search = searchText;
}
Wrapper.find({ ref: "search" }).trigger("keyup.enter")
Wrapper.find({ ref: "search" }).trigger("keydown.enter")
};
/**
tests/unit/Dropdown.spec.js
+2 -2
View File
@@ -109,14 +109,14 @@ describe("Toggling Dropdown", () => {
expect(spy).toHaveBeenCalled();
});
it("should remove existing search text on escape keyup", () => {
it("should remove existing search text on escape keydown", () => {
const Select = selectWithProps({
value: [{ label: "one" }],
options: [{ label: "one" }]
});
Select.vm.search = "foo";
Select.find('.vs__search').trigger('keyup.esc')
Select.find('.vs__search').trigger('keydown.esc')
expect(Select.vm.search).toEqual("");
});
tests/unit/TypeAhead.spec.js
+4 -4
View File
@@ -23,7 +23,7 @@ describe("Moving the Typeahead Pointer", () => {
Select.vm.typeAheadPointer = 1;
Select.find({ ref: "search" }).trigger("keyup.up");
Select.find({ ref: "search" }).trigger("keydown.up");
expect(Select.vm.typeAheadPointer).toEqual(0);
});
@@ -33,7 +33,7 @@ describe("Moving the Typeahead Pointer", () => {
Select.vm.typeAheadPointer = 1;
Select.find({ ref: "search" }).trigger("keyup.down");
Select.find({ ref: "search" }).trigger("keydown.down");
expect(Select.vm.typeAheadPointer).toEqual(2);
});
@@ -53,7 +53,7 @@ describe("Moving the Typeahead Pointer", () => {
Select.vm.typeAheadPointer = 1;
Select.find({ ref: "search" }).trigger("keyup.up");
Select.find({ ref: "search" }).trigger("keydown.up");
expect(spy).toHaveBeenCalled();
});
@@ -63,7 +63,7 @@ describe("Moving the Typeahead Pointer", () => {
Select.vm.typeAheadPointer = 1;
Select.find({ ref: "search" }).trigger("keyup.down");
Select.find({ ref: "search" }).trigger("keydown.down");
expect(spy).toHaveBeenCalled();
});