mirrors/vue-meta
2
0
Fork 0
mirror of https://github.com/tenrok/vue-meta.git synced 2026-06-24 19:30:35 +03:00
Code Activity

fix: dont change title when value is undefined (fix #396)

Browse Source
This commit is contained in:
pimlie
2019-06-22 16:15:49 +02:00
parent 4ca3050112
commit 90f9710f26
5 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/basic/index.html
+11 -4
View File
@@ -1,5 +1,12 @@
<!DOCTYPE html> <!DOCTYPE html>
<link rel="stylesheet" href="/global.css"> <html>
<a href="/">&larr; Examples index</a> <head>
<div id="app"></div> <title>Basic Title</title>
<script src="/__build__/basic.js"></script> <link rel="stylesheet" href="/global.css">
</head>
<body>
<a href="/">&larr; Examples index</a>
<div id="app"></div>
<script src="/__build__/basic.js"></script>
</body>
</html>
src/client/updaters/title.js
+5 -1
View File
@@ -3,6 +3,10 @@
* *
* @param {String} title - the new title of the document * @param {String} title - the new title of the document
*/ */
export default function updateTitle(title = document.title) { export default function updateTitle(title) {
if (title === undefined) {
return
}
document.title = title document.title = title
} }
src/shared/constants.js
+1 -1
View File
@@ -4,7 +4,7 @@
// set some sane defaults // set some sane defaults
export const defaultInfo = { export const defaultInfo = {
title: '', title: undefined,
titleChunk: '', titleChunk: '',
titleTemplate: '%s', titleTemplate: '%s',
htmlAttrs: {}, htmlAttrs: {},
test/unit/components.test.js
+1 -1
View File
@@ -90,7 +90,7 @@ describe('client', () => {
jest.runAllTimers() jest.runAllTimers()
metaInfo = getMetaInfo(wrapper.vm.$parent) metaInfo = getMetaInfo(wrapper.vm.$parent)
expect(metaInfo.title).toEqual('') expect(metaInfo.title).toEqual(undefined)
}) })
test('meta-info can be rendered with inject', () => { test('meta-info can be rendered with inject', () => {
test/unit/getMetaInfo.test.js
+3 -3
View File
@@ -13,7 +13,7 @@ describe('getMetaInfo', () => {
const component = new Vue() const component = new Vue()
expect(getMetaInfo(component)).toEqual({ expect(getMetaInfo(component)).toEqual({
title: '', title: undefined,
titleChunk: '', titleChunk: '',
titleTemplate: '%s', titleTemplate: '%s',
htmlAttrs: {}, htmlAttrs: {},
@@ -654,7 +654,7 @@ describe('getMetaInfo', () => {
}) })
expect(getMetaInfo(component)).toEqual({ expect(getMetaInfo(component)).toEqual({
title: '', title: undefined,
titleChunk: '', titleChunk: '',
titleTemplate: '%s', titleTemplate: '%s',
htmlAttrs: {}, htmlAttrs: {},
@@ -802,7 +802,7 @@ describe('getMetaInfo', () => {
}) })
expect(getMetaInfo(component)).toEqual({ expect(getMetaInfo(component)).toEqual({
title: '', title: undefined,
titleChunk: '', titleChunk: '',
titleTemplate: '%s', titleTemplate: '%s',
htmlAttrs: {}, htmlAttrs: {},