mirrors/vue-meta
2
0
Fork 0
mirror of https://github.com/tenrok/vue-meta.git synced 2026-06-24 22:50:34 +03:00
Code Activity

Clear Interval if the component doesn't have the $el property

Browse Source 
Using the vuelidate plugin creates components that do not have an $el property, but still have _hasMetaInfo set to true, which results in the setInterval never being cleared. There may be other plugins that create similar components.

Changing the line to if (this.$el && this.$el.offsetParent !== null) return would resolve this issue.
This commit is contained in:
Eduardo Gómez Vásquez
2018-03-08 11:52:52 +01:00
committed by GitHub
parent 776ddf62a2
commit 6f2b87c169
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/plugin.js
+1 -1
View File
@@ -87,7 +87,7 @@ export default function VueMeta (Vue, options = {}) {
if (this._hasMetaInfo) { if (this._hasMetaInfo) {
// Wait that element is hidden before refreshing meta tags (to support animations) // Wait that element is hidden before refreshing meta tags (to support animations)
const interval = setInterval(() => { const interval = setInterval(() => {
if (this.$el.offsetParent !== null) return if (this.$el && this.$el.offsetParent !== null) return
clearInterval(interval) clearInterval(interval)
batchID = batchUpdate(batchID, () => this.$meta().refresh()) batchID = batchUpdate(batchID, () => this.$meta().refresh())
}, 50) }, 50)