From 66e4fb4e3e0853921759e3d9590c7df0f0f5dd74 Mon Sep 17 00:00:00 2001
From: pimlie <pimlie@hotmail.com>
Date: Mon, 11 Feb 2019 15:59:01 +0100
Subject: [PATCH] fix: also render boolean attributes correctly for tags

---
 src/server/generators/tag.js |  4 ++--
 test/utils/meta-info-data.js | 16 +++++++---------
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/server/generators/tag.js b/src/server/generators/tag.js
index 1740154..ae481de 100644
--- a/src/server/generators/tag.js
+++ b/src/server/generators/tag.js
@@ -1,4 +1,4 @@
-import { tagsWithoutEndTag, tagsWithInnerContent, tagAttributeAsInnerContent } from '../../shared/constants'
+import { booleanHtmlAttributes, tagsWithoutEndTag, tagsWithInnerContent, tagAttributeAsInnerContent } from '../../shared/constants'
 import { isUndefined } from '../../shared/typeof'
 
 /**
@@ -36,7 +36,7 @@ export default function tagGenerator({ attribute, tagIDKeyName } = {}, type, tag
             prefix = 'data-'
           }
 
-          return isUndefined(tag[attr])
+          return isUndefined(tag[attr]) || booleanHtmlAttributes.includes(attr)
             ? `${attrsStr} ${prefix}${attr}`
             : `${attrsStr} ${prefix}${attr}="${tag[attr]}"`
         }, '')
diff --git a/test/utils/meta-info-data.js b/test/utils/meta-info-data.js
index cff7c3a..261b760 100644
--- a/test/utils/meta-info-data.js
+++ b/test/utils/meta-info-data.js
@@ -117,12 +117,15 @@ const metaInfoData = {
         { src: 'src', async: true, defer: true, body: true }
       ],
       expect: [
-        '<script data-vue-meta="true" src="src" async="true" defer="true" data-vmid="content"></script>',
-        '<script data-vue-meta="true" src="src" async="true" defer="true" data-body="true"></script>'
+        '<script data-vue-meta="true" src="src" async defer data-vmid="content"></script>',
+        '<script data-vue-meta="true" src="src" async defer data-body="true"></script>'
       ],
       test(side, defaultTest) {
         return () => {
           if (side === 'client') {
+            for (const index in this.expect) {
+              this.expect[index] = this.expect[index].replace(/(async|defer)/g, '$1="true"')
+            }
             const tags = defaultTest()
 
             expect(tags.addedTags.script[0].parentNode.tagName).toBe('HEAD')
@@ -139,15 +142,10 @@ const metaInfoData = {
         }
       }
     },
+    // this test only runs for client so we can directly expect wrong boolean attributes
     change: {
       data: [{ src: 'src', async: true, defer: true, [defaultOptions.tagIDKeyName]: 'content2' }],
-      expect: ['<script data-vue-meta="true" src="src" async="true" defer data-vmid="content2"></script>'],
-      test(side, defaultTest) {
-        if (side === 'client') {
-          // jsdom doesnt generate valid boolean attributes
-          this.expect[0] = this.expect[0].replace('defer', 'defer="true"')
-        }
-      }
+      expect: ['<script data-vue-meta="true" src="src" async="true" defer="true" data-vmid="content2"></script>']
     },
     remove: {
       data: [],