mirrors/vue-meta
2
0
Fork 0
mirror of https://github.com/tenrok/vue-meta.git synced 2026-06-24 14:50:34 +03:00
Code Activity

refactor: optimize query selector

Browse Source
This commit is contained in:
Clark Du
2017-11-04 22:51:40 +08:00
parent 5b637d5853
commit 61baf27f32
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/updaters/updateTags.js
+5 -4
View File
@@ -13,8 +13,8 @@ export default function _updateTags (options = {}) {
* @return {Object} - a representation of what tags changed * @return {Object} - a representation of what tags changed
*/ */
return function updateTags (type, tags, headTag, bodyTag) { return function updateTags (type, tags, headTag, bodyTag) {
const nodes = document.querySelectorAll(`${type}[${attribute}]`) const oldHeadTags = toArray(headTag.querySelectorAll(`${type}[${attribute}]`))
const oldTags = toArray(nodes) const oldBodyTags = toArray(bodyTag.querySelectorAll(`${type}[${attribute}][body="true"]`))
const newTags = [] const newTags = []
let indexToDelete let indexToDelete
@@ -35,6 +35,7 @@ export default function _updateTags (options = {}) {
if (tags && tags.length) { if (tags && tags.length) {
tags.forEach((tag) => { tags.forEach((tag) => {
const newElement = document.createElement(type) const newElement = document.createElement(type)
const oldTags = tag.body !== true ? oldHeadTags : oldBodyTags
for (const attr in tag) { for (const attr in tag) {
if (tag.hasOwnProperty(attr)) { if (tag.hasOwnProperty(attr)) {
@@ -70,10 +71,10 @@ export default function _updateTags (options = {}) {
} }
}) })
} }
const oldTags = oldHeadTags.concat(oldBodyTags)
oldTags.forEach((tag) => tag.parentNode.removeChild(tag)) oldTags.forEach((tag) => tag.parentNode.removeChild(tag))
newTags.forEach((tag) => { newTags.forEach((tag) => {
if (tag.body === true) { if (tag.getAttribute('body') === 'true') {
bodyTag.appendChild(tag) bodyTag.appendChild(tag)
} else { } else {
headTag.appendChild(tag) headTag.appendChild(tag)