From 2141bab00ce9fb5cd16eaf22c0f28e6dcb36bdd9 Mon Sep 17 00:00:00 2001 From: "Xin Du (Clark)" Date: Thu, 28 Mar 2019 12:30:29 +0000 Subject: [PATCH] feat: don't generate title tag if title is empty (#334) * fix: not generate title tag if title is empty * fix: align title to document.title api * refactor: trim data --- src/server/generators/titleGenerator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/generators/titleGenerator.js b/src/server/generators/titleGenerator.js index 5ac091d..3cecb02 100644 --- a/src/server/generators/titleGenerator.js +++ b/src/server/generators/titleGenerator.js @@ -11,7 +11,7 @@ export default function _titleGenerator (options = {}) { return function titleGenerator (type, data) { return { text () { - return `<${type} ${attribute}="true">${data}` + return String(data).trim() ? `<${type} ${attribute}="true">${data}` : '' } } }