#11464 - Fix JS noConflict mode - Refactor all plugins to use an internal reference to the jQuery plugin, because in noConflict mode you can never expect to be defined on the jQuery object

js/tests/unit/popover.js

@@ -1,38 +1,47 @@
 $(function () {
 
-  module('popover')
-
-  test('should provide no conflict', function () {
-    var popover = $.fn.popover.noConflict()
-    ok(!$.fn.popover, 'popover was set back to undefined (org value)')
-    $.fn.popover = popover
-  })
+  module('popover plugin')
 
   test('should be defined on jquery object', function () {
     var div = $('<div></div>')
     ok(div.popover, 'popover method is defined')
   })
 
+  module('popover', {
+    setup: function() {
+      // Run all tests in noConflict mode -- it's the only way to ensure that the plugin works in noConflict mode
+      $.fn.bootstrapPopover = $.fn.popover.noConflict()
+    },
+    teardown: function() {
+      $.fn.popover = $.fn.bootstrapPopover
+      delete $.fn.bootstrapPopover
+    }
+  })
+
+  test('should provide no conflict', function () {
+    ok(!$.fn.popover, 'popover was set back to undefined (org value)')
+  })
+
   test('should return element', function () {
     var div = $('<div></div>')
-    ok(div.popover() == div, 'document.body returned')
+    ok(div.bootstrapPopover() == div, 'document.body returned')
   })
 
   test('should render popover element', function () {
     $.support.transition = false
     var popover = $('<a href="#" title="mdo" data-content="http://twitter.com/mdo">@mdo</a>')
       .appendTo('#qunit-fixture')
-      .popover('show')
+      .bootstrapPopover('show')
 
     ok($('.popover').length, 'popover was inserted')
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover removed')
   })
 
   test('should store popover instance in popover data object', function () {
     $.support.transition = false
     var popover = $('<a href="#" title="mdo" data-content="http://twitter.com/mdo">@mdo</a>')
-      .popover()
+      .bootstrapPopover()
 
     ok(!!popover.data('bs.popover'), 'popover instance exists')
   })
@@ -41,7 +50,7 @@ $(function () {
     $.support.transition = false
     var popover = $('<a href="#">@fat</a>')
       .appendTo('#qunit-fixture')
-      .popover({
+      .bootstrapPopover({
         title: function () {
           return '@fat'
         },
@@ -50,13 +59,13 @@ $(function () {
         }
       })
 
-    popover.popover('show')
+    popover.bootstrapPopover('show')
 
     ok($('.popover').length, 'popover was inserted')
     equal($('.popover .popover-title').text(), '@fat', 'title correctly inserted')
     equal($('.popover .popover-content').text(), 'loves writing tests （╯°□°）╯︵ ┻━┻', 'content correctly inserted')
 
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover was removed')
     $('#qunit-fixture').empty()
   })
@@ -68,24 +77,24 @@ $(function () {
 
     var popover = $('<a href="#">@fat</a>')
       .appendTo('#qunit-fixture')
-      .popover({
+      .bootstrapPopover({
         content: function () {
           return $div
         }
       })
 
-    popover.popover('show')
+    popover.bootstrapPopover('show')
     ok($('.popover').length, 'popover was inserted')
     equal($('.popover .popover-content').html(), $div, 'content correctly inserted')
 
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover was removed')
 
-    popover.popover('show')
+    popover.bootstrapPopover('show')
     ok($('.popover').length, 'popover was inserted')
     equal($('.popover .popover-content').html(), $div, 'content correctly inserted')
 
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover was removed')
     $('#qunit-fixture').empty()
   })
@@ -94,14 +103,14 @@ $(function () {
     $.support.transition = false
     var popover = $('<a href="#" title="@mdo" data-content="loves data attributes (づ｡◕‿‿◕｡)づ ︵ ┻━┻" >@mdo</a>')
       .appendTo('#qunit-fixture')
-      .popover()
-      .popover('show')
+      .bootstrapPopover()
+      .bootstrapPopover('show')
 
     ok($('.popover').length, 'popover was inserted')
     equal($('.popover .popover-title').text(), '@mdo', 'title correctly inserted')
     equal($('.popover .popover-content').text(), 'loves data attributes (づ｡◕‿‿◕｡)づ ︵ ┻━┻', 'content correctly inserted')
 
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover was removed')
     $('#qunit-fixture').empty()
   })
@@ -111,17 +120,17 @@ $(function () {
     $.support.transition = false
     var popover = $('<a href="#" title="@mdo" data-content="loves data attributes (づ｡◕‿‿◕｡)づ ︵ ┻━┻" >@mdo</a>')
       .appendTo('#qunit-fixture')
-      .popover({
+      .bootstrapPopover({
         title: 'ignored title option',
         content: 'ignored content option'
       })
-      .popover('show')
+      .bootstrapPopover('show')
 
     ok($('.popover').length, 'popover was inserted')
     equal($('.popover .popover-title').text(), '@mdo', 'title correctly inserted')
     equal($('.popover .popover-content').text(), 'loves data attributes (づ｡◕‿‿◕｡)づ ︵ ┻━┻', 'content correctly inserted')
 
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover was removed')
     $('#qunit-fixture').empty()
   })
@@ -130,29 +139,29 @@ $(function () {
     $.support.transition = false
     var popover = $('<a href="#">@fat</a>')
       .appendTo('#qunit-fixture')
-      .popover({
+      .bootstrapPopover({
         title: 'Test',
         content: 'Test',
         template: '<div class="popover foobar"><div class="arrow"></div><div class="inner"><h3 class="title"></h3><div class="content"><p></p></div></div></div>'
       })
 
-    popover.popover('show')
+    popover.bootstrapPopover('show')
 
     ok($('.popover').length, 'popover was inserted')
     ok($('.popover').hasClass('foobar'), 'custom class is present')
 
-    popover.popover('hide')
+    popover.bootstrapPopover('hide')
     ok(!$('.popover').length, 'popover was removed')
     $('#qunit-fixture').empty()
   })
 
   test('should destroy popover', function () {
-    var popover = $('<div/>').popover({trigger: 'hover'}).on('click.foo', function () {})
+    var popover = $('<div/>').bootstrapPopover({trigger: 'hover'}).on('click.foo', function () {})
     ok(popover.data('bs.popover'), 'popover has data')
     ok($._data(popover[0], 'events').mouseover && $._data(popover[0], 'events').mouseout, 'popover has hover event')
     ok($._data(popover[0], 'events').click[0].namespace == 'foo', 'popover has extra click.foo event')
-    popover.popover('show')
-    popover.popover('destroy')
+    popover.bootstrapPopover('show')
+    popover.bootstrapPopover('destroy')
     ok(!popover.hasClass('in'), 'popover is hidden')
     ok(!popover.data('popover'), 'popover does not have data')
     ok($._data(popover[0],'events').click[0].namespace == 'foo', 'popover still has click.foo')