From 6b5850212e0c3a9f5f82d22eda0f6240d01f2f5a Mon Sep 17 00:00:00 2001 From: Johann-S Date: Sun, 27 Aug 2017 00:57:27 +0200 Subject: [PATCH] Second element of find and findOne should be optional, not the first one --- js/src/alert.js | 2 +- js/src/dom/selectorEngine.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/js/src/alert.js b/js/src/alert.js index d23c4659c..1bdd9706a 100644 --- a/js/src/alert.js +++ b/js/src/alert.js @@ -84,7 +84,7 @@ class Alert { let parent = false if (selector) { - parent = SelectorEngine.find(selector)[0] + parent = SelectorEngine.findOne(selector) } if (!parent) { diff --git a/js/src/dom/selectorEngine.js b/js/src/dom/selectorEngine.js index bef616988..0cff83ef9 100644 --- a/js/src/dom/selectorEngine.js +++ b/js/src/dom/selectorEngine.js @@ -46,19 +46,19 @@ const SelectorEngine = { return fnMatches.call(element, selector) }, - find(element = document, selector) { + find(selector, element = document) { if (typeof selector !== 'string') { return null } if (selector.indexOf('#') === 0) { - return SelectorEngine.findOne(element, selector) + return SelectorEngine.findOne(selector, element) } return element.querySelectorAll(selector) }, - findOne(element = document, selector) { + findOne(selector, element = document) { if (typeof selector !== 'string') { return null }