2
0
mirror of https://github.com/tenrok/bootstrap.git synced 2026-06-05 16:42:29 +03:00

Remove potential false positive assertions (#33288)

* Remove potential false positive assertions

querySelector() returns null but

expect(document.querySelector('...')).toBeDefined()

tests that the value is not undefined

* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests

* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call

* convert more cases to not.toBeNull assertions

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
This commit is contained in:
Ben Lertlumprasertkul
2021-05-11 06:45:57 +01:00
committed by GitHub
parent 9c3ab6557e
commit 052def4568
13 changed files with 67 additions and 67 deletions
+2 -2
View File
@@ -1213,7 +1213,7 @@ describe('Carousel', () => {
jQueryMock.fn.carousel.call(jQueryMock)
expect(Carousel.getInstance(div)).toBeDefined()
expect(Carousel.getInstance(div)).not.toBeNull()
})
it('should not re create a carousel', () => {
@@ -1271,7 +1271,7 @@ describe('Carousel', () => {
window.dispatchEvent(loadEvent)
expect(Carousel.getInstance(carouselEl)).toBeDefined()
expect(Carousel.getInstance(carouselEl)).not.toBeNull()
})
it('should create carousel and go to the next slide on click (with real button controls)', done => {