From d1178cad4c4fe21be3d36a5a89c1590f474b4d89 Mon Sep 17 00:00:00 2001 From: George Cheng Date: Mon, 31 Mar 2025 12:00:51 -0700 Subject: [PATCH] chore(types): move AxiosStatic#create to AxiosInstance#create (#5096) * Add the bad test case. * Fix and pass the test * Update index.d.cts --------- Co-authored-by: Jay --- index.d.cts | 2 +- index.d.ts | 2 +- test/module/typings/esm/index.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/index.d.cts b/index.d.cts index 7d2c77a..482dc89 100644 --- a/index.d.cts +++ b/index.d.cts @@ -508,6 +508,7 @@ declare namespace axios { , D = any>(config: AxiosRequestConfig): Promise; , D = any>(url: string, config?: AxiosRequestConfig): Promise; + create(config?: CreateAxiosDefaults): AxiosInstance; defaults: Omit & { headers: HeadersDefaults & { [key: string]: AxiosHeaderValue @@ -526,7 +527,6 @@ declare namespace axios { } interface AxiosStatic extends AxiosInstance { - create(config?: CreateAxiosDefaults): AxiosInstance; Cancel: CancelStatic; CancelToken: CancelTokenStatic; Axios: typeof Axios; diff --git a/index.d.ts b/index.d.ts index e968ce8..7989802 100644 --- a/index.d.ts +++ b/index.d.ts @@ -514,6 +514,7 @@ export interface AxiosInstance extends Axios { , D = any>(config: AxiosRequestConfig): Promise; , D = any>(url: string, config?: AxiosRequestConfig): Promise; + create(config?: CreateAxiosDefaults): AxiosInstance; defaults: Omit & { headers: HeadersDefaults & { [key: string]: AxiosHeaderValue @@ -548,7 +549,6 @@ export function all(values: Array>): Promise; export function mergeConfig(config1: AxiosRequestConfig, config2: AxiosRequestConfig): AxiosRequestConfig; export interface AxiosStatic extends AxiosInstance { - create(config?: CreateAxiosDefaults): AxiosInstance; Cancel: CancelStatic; CancelToken: CancelTokenStatic; Axios: typeof Axios; diff --git a/test/module/typings/esm/index.ts b/test/module/typings/esm/index.ts index 043e516..088dacf 100644 --- a/test/module/typings/esm/index.ts +++ b/test/module/typings/esm/index.ts @@ -237,7 +237,7 @@ axios.request({ // Instances const instance1: AxiosInstance = axios.create(); -const instance2: AxiosInstance = axios.create(config); +const instance2: AxiosInstance = instance1.create(config); instance1(config) .then(handleResponse)