mirrors/axios
2
0
Fork 0
mirror of https://github.com/tenrok/axios.git synced 2026-06-20 20:00:40 +03:00
Code Activity

In browsers check for XMLHttpRequest, not window

Browse Source 
In nodejs testing environment it's possible to use https://github.com/tmpvar/jsdom library to define a window object, but you still want to use node http adapter. Due to those diverse testing environmnents, I propose to test for XMLHttpRequest directly, because window global object is not a sure sign of a browser environment anymore.
This commit is contained in:
Tomáš Holas
2015-07-13 09:42:27 +02:00
parent db85c7bf3a
commit ca42bb1d2a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/core/dispatchRequest.js
+1 -1
View File
@@ -11,7 +11,7 @@ module.exports = function dispatchRequest(config) {
return new Promise(function (resolve, reject) { return new Promise(function (resolve, reject) {
try { try {
// For browsers use XHR adapter // For browsers use XHR adapter
if (typeof window !== 'undefined') { if (typeof XMLHttpRequest !== 'undefined') {
require('../adapters/xhr')(resolve, reject, config); require('../adapters/xhr')(resolve, reject, config);
} }
// For node use HTTP adapter // For node use HTTP adapter