mirrors/axios
2
0
Fork 0
mirror of https://github.com/tenrok/axios.git synced 2026-06-20 20:00:40 +03:00
Code Activity

Revert "fix: silentJSONParsing=false should throw on invalid JSON (#7253) (#7…" (#7298)

Browse Source 
This reverts commit 7d19335e43.
This commit is contained in:
Jay
2025-12-08 14:19:20 +02:00
committed by GitHub
parent e0a120620e
commit a4230f5581
2 changed files with 2 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/defaults/index.js
+1 -1
View File
@@ -108,7 +108,7 @@ const defaults = {
if (data && utils.isString(data) && ((forcedJSONParsing && !this.responseType) || JSONRequested)) { if (data && utils.isString(data) && ((forcedJSONParsing && !this.responseType) || JSONRequested)) {
const silentJSONParsing = transitional && transitional.silentJSONParsing; const silentJSONParsing = transitional && transitional.silentJSONParsing;
const strictJSONParsing = !silentJSONParsing; const strictJSONParsing = !silentJSONParsing && JSONRequested;
try { try {
return JSON.parse(data, this.parseReviver); return JSON.parse(data, this.parseReviver);
test/regression_silent_json.js
-69
View File
@@ -1,69 +0,0 @@
import assert from 'assert';
import axios from '../index.js';
describe('Regression: Silent JSON Parsing', function () {
beforeEach(function () {
// Mock adapter to return invalid JSON
axios.defaults.adapter = async (config) => {
return {
data: '{ invalid json }',
status: 200,
statusText: 'OK',
headers: {},
config
};
};
});
afterEach(function () {
delete axios.defaults.adapter;
});
it('should throw SyntaxError when silentJSONParsing is false', async function () {
try {
await axios.get('/test', {
transitional: {
silentJSONParsing: false
}
});
assert.fail('Should have thrown error');
} catch (err) {
assert.ok(err.name === 'SyntaxError' || err.code === 'ERR_BAD_RESPONSE', 'Error should be SyntaxError or ERR_BAD_RESPONSE');
}
});
it('should return raw string when silentJSONParsing is true (default)', async function () {
const response = await axios.get('/test', {
transitional: {
silentJSONParsing: true
}
});
assert.strictEqual(response.data, '{ invalid json }');
});
it('should throw SyntaxError when responseType is json (legacy behavior)', async function () {
try {
await axios.get('/test', {
responseType: 'json',
transitional: {
silentJSONParsing: false
}
});
assert.fail('Should have thrown error');
} catch (err) {
assert.ok(err.name === 'SyntaxError' || err.code === 'ERR_BAD_RESPONSE', 'Error should be SyntaxError or ERR_BAD_RESPONSE');
}
});
it('should swallow error when silentJSONParsing is true and responseType is json (legacy behavior)', async function () {
const response = await axios.get('/test', {
responseType: 'json',
transitional: {
silentJSONParsing: true
}
});
assert.strictEqual(response.data, '{ invalid json }');
});
});