mirror of
https://github.com/tenrok/axios.git
synced 2026-06-23 20:40:40 +03:00
docs: updated contributing guide to no longer contain the release section as this is not needed
This commit is contained in:
@@ -9,6 +9,7 @@ As a collaborator, you will be involved with axios with some administrative resp
|
|||||||
1. __Answer questions.__ It is not expected that you provide answers to questions that aren’t relevant, nor do you need to mentor people on how to use JavaScript, etc. If the question is not directly about the module, please close the issue. If the question stems from poor documentation, please update the docs and consider adding a code example. In any event try to be helpful and remember that there’s no such thing as a stupid question.
|
1. __Answer questions.__ It is not expected that you provide answers to questions that aren’t relevant, nor do you need to mentor people on how to use JavaScript, etc. If the question is not directly about the module, please close the issue. If the question stems from poor documentation, please update the docs and consider adding a code example. In any event try to be helpful and remember that there’s no such thing as a stupid question.
|
||||||
|
|
||||||
1. __Assist with PRs.__ By encouraging contributors to supply a PR for their own issue this is ideally where most of your attention will be focused. Keep a few things in mind as you review PRs.
|
1. __Assist with PRs.__ By encouraging contributors to supply a PR for their own issue this is ideally where most of your attention will be focused. Keep a few things in mind as you review PRs.
|
||||||
|
|
||||||
- When fixing a bug: does the PR adequately solve the problem without introducing any regressions?
|
- When fixing a bug: does the PR adequately solve the problem without introducing any regressions?
|
||||||
- When implementing a feature: does the feature fit within the scope of axios?
|
- When implementing a feature: does the feature fit within the scope of axios?
|
||||||
- When removing functionality: is it properly deprecated with a warning?
|
- When removing functionality: is it properly deprecated with a warning?
|
||||||
|
|||||||
+1
-8
@@ -12,7 +12,7 @@ Please follow [conventional commits](https://www.conventionalcommits.org/en/v1.0
|
|||||||
|
|
||||||
## Testing
|
## Testing
|
||||||
|
|
||||||
Please update the tests to reflect your code changes. Pull requests will not be accepted if they are failing on [Travis CI](https://travis-ci.org/axios/axios).
|
Please update the tests to reflect your code changes. Pull requests will not be accepted if they are failing on GitHub actions.
|
||||||
|
|
||||||
## Documentation
|
## Documentation
|
||||||
|
|
||||||
@@ -28,13 +28,6 @@ Please update the [docs](README.md) accordingly so that there are no discrepanci
|
|||||||
|
|
||||||
Please don't include changes to `dist/` in your pull request. This should only be updated when releasing a new version.
|
Please don't include changes to `dist/` in your pull request. This should only be updated when releasing a new version.
|
||||||
|
|
||||||
## Releasing
|
|
||||||
|
|
||||||
Releasing a new version is mostly automated. For now the [CHANGELOG](https://github.com/axios/axios/blob/master/CHANGELOG.md) requires being updated manually. Once this has been done run the commands below. Versions should follow [semantic versioning](http://semver.org/).
|
|
||||||
|
|
||||||
- `npm version <newversion> -m "Releasing %s"`
|
|
||||||
- `npm publish`
|
|
||||||
|
|
||||||
## Running Examples
|
## Running Examples
|
||||||
|
|
||||||
Examples are included in part to allow manual testing.
|
Examples are included in part to allow manual testing.
|
||||||
|
|||||||
Reference in New Issue
Block a user