mirror of
https://github.com/tenrok/axios.git
synced 2026-06-20 20:00:40 +03:00
Fixing building url with hash mark (#1771)
This commit fix building url with hash map (fragment identifier) when parameters are present: they must not be added after `#`, because client cut everything after `#`
This commit is contained in:
committed by
Khaled Garbaya
parent
21ae22dbd3
commit
81eaa3db4c
@@ -59,6 +59,11 @@ module.exports = function buildURL(url, params, paramsSerializer) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if (serializedParams) {
|
if (serializedParams) {
|
||||||
|
var hashmarkIndex = url.indexOf('#');
|
||||||
|
if (hashmarkIndex !== -1) {
|
||||||
|
url = url.slice(0, hashmarkIndex);
|
||||||
|
}
|
||||||
|
|
||||||
url += (url.indexOf('?') === -1 ? '?' : '&') + serializedParams;
|
url += (url.indexOf('?') === -1 ? '?' : '&') + serializedParams;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -54,6 +54,12 @@ describe('helpers::buildURL', function () {
|
|||||||
})).toEqual('/foo?query=bar&start=0&length=5');
|
})).toEqual('/foo?query=bar&start=0&length=5');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('should correct discard url hash mark', function () {
|
||||||
|
expect(buildURL('/foo?foo=bar#hash', {
|
||||||
|
query: 'baz'
|
||||||
|
})).toEqual('/foo?foo=bar&query=baz');
|
||||||
|
});
|
||||||
|
|
||||||
it('should use serializer if provided', function () {
|
it('should use serializer if provided', function () {
|
||||||
serializer = sinon.stub();
|
serializer = sinon.stub();
|
||||||
params = {foo: 'bar'};
|
params = {foo: 'bar'};
|
||||||
|
|||||||
Reference in New Issue
Block a user