mirrors/axios
2
0
Fork 0
mirror of https://github.com/tenrok/axios.git synced 2026-06-11 18:02:32 +03:00
Code Activity

fix(sec): CVE-2024-39338 (#6539) (#6543)

Browse Source 
* fix(sec): cve-2024-39338 (#6539)

* fix(sec): fix test
This commit is contained in:
Lev Pachmanov
2024-08-13 21:43:05 +03:00
committed by GitHub
parent 07a661a2a6
commit 6b6b605eaf
4 changed files with 47 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/specs/helpers/isAbsoluteURL.spec.js
+2 -2
View File
@@ -12,8 +12,8 @@ describe('helpers::isAbsoluteURL', function () {
expect(isAbsoluteURL('!valid://example.com/')).toBe(false);
});
it('should return false if URL is protocol-relative', function () {
expect(isAbsoluteURL('//example.com/')).toBe(false);
it('should return true if URL is protocol-relative', function () {
expect(isAbsoluteURL('//example.com/')).toBe(true);
});
it('should return false if URL is relative', function () {
test/unit/regression/SNYK-JS-AXIOS-7361793.js
+42 -6
View File
@@ -4,6 +4,9 @@
import axios from '../../../index.js';
import http from 'http';
import assert from 'assert';
import utils from '../../../lib/utils.js';
import platform from '../../../lib/platform/index.js';
const GOOD_PORT = 4666;
const BAD_PORT = 4667;
@@ -27,7 +30,7 @@ describe('Server-Side Request Forgery (SSRF)', () => {
badServer.close();
});
it('should not fetch bad server', async () => {
it('should not fetch in server-side mode', async () => {
const ssrfAxios = axios.create({
baseURL: 'http://localhost:' + String(GOOD_PORT),
});
@@ -36,10 +39,43 @@ describe('Server-Side Request Forgery (SSRF)', () => {
// Malicious payload is as below.
const userId = '/localhost:' + String(BAD_PORT);
const response = await ssrfAxios.get(`/${userId}`);
assert.strictEqual(response.data, 'good');
assert.strictEqual(response.config.baseURL, 'http://localhost:' + String(GOOD_PORT));
assert.strictEqual(response.config.url, '//localhost:' + String(BAD_PORT));
assert.strictEqual(response.request.res.responseUrl, 'http://localhost:' + String(GOOD_PORT) + '/localhost:' + String(BAD_PORT));
try {
await ssrfAxios.get(`/${userId}`);
} catch (error) {
assert.ok(error.message.startsWith('Invalid URL'));
return;
}
assert.fail('Expected an error to be thrown');
});
describe('should fetch in client-side mode', () => {
let hasBrowserEnv, origin;
before(() => {
hasBrowserEnv = utils.hasBrowserEnv;
origin = platform.origin;
utils.hasBrowserEnv = true;
platform.origin = 'http://localhost:' + String(GOOD_PORT);
});
after(() => {
utils.hasBrowserEnv = hasBrowserEnv;
platform.origin = origin;
});
it('should fetch in client-side mode', async () => {
utils.hasBrowserEnv = true;
const ssrfAxios = axios.create({
baseURL: 'http://localhost:' + String(GOOD_PORT),
});
// Good payload would be `userId = '12345'`
// Malicious payload is as below.
const userId = '/localhost:' + String(BAD_PORT);
const response = await ssrfAxios.get(`/${userId}`);
assert.strictEqual(response.data, 'bad');
assert.strictEqual(response.config.baseURL, 'http://localhost:' + String(GOOD_PORT));
assert.strictEqual(response.config.url, '//localhost:' + String(BAD_PORT));
assert.strictEqual(response.request.res.responseUrl, 'http://localhost:' + String(BAD_PORT) + '/');
});
});
});