2
0
mirror of https://github.com/tenrok/axios.git synced 2026-06-20 20:00:40 +03:00

Remove dependency on is-buffer (#1816)

* Remove dependency on is-buffer from package.json
This commit is contained in:
Angelos Chalaris
2019-11-18 08:53:27 +02:00
committed by Yasu Flores
parent 0cc22c2f42
commit 1a32ca0601
3 changed files with 18 additions and 3 deletions
+11 -1
View File
@@ -1,7 +1,6 @@
'use strict'; 'use strict';
var bind = require('./helpers/bind'); var bind = require('./helpers/bind');
var isBuffer = require('is-buffer');
/*global toString:true*/ /*global toString:true*/
@@ -19,6 +18,17 @@ function isArray(val) {
return toString.call(val) === '[object Array]'; return toString.call(val) === '[object Array]';
} }
/**
* Determine if a value is a Buffer
*
* @param {Object} val The value to test
* @returns {boolean} True if value is a Buffer, otherwise false
*/
function isBuffer(val) {
return ![undefined, null].includes(val) && val.constructor === Buffer;
}
/** /**
* Determine if a value is an ArrayBuffer * Determine if a value is an ArrayBuffer
* *
+1 -2
View File
@@ -73,8 +73,7 @@
}, },
"typings": "./index.d.ts", "typings": "./index.d.ts",
"dependencies": { "dependencies": {
"follow-redirects": "1.5.10", "follow-redirects": "^1.4.1"
"is-buffer": "^2.0.2"
}, },
"bundlesize": [ "bundlesize": [
{ {
+6
View File
@@ -7,6 +7,12 @@ describe('utils::isX', function () {
expect(utils.isArray({length: 5})).toEqual(false); expect(utils.isArray({length: 5})).toEqual(false);
}); });
it('should validate Buffer', function () {
expect(utils.isBuffer(Buffer.from('a'))).toEqual(true);
expect(utils.isBuffer(null)).toEqual(false);
expect(utils.isBuffer(undefined)).toEqual(false);
});
it('should validate ArrayBuffer', function () { it('should validate ArrayBuffer', function () {
expect(utils.isArrayBuffer(new ArrayBuffer(2))).toEqual(true); expect(utils.isArrayBuffer(new ArrayBuffer(2))).toEqual(true);
expect(utils.isArrayBuffer({})).toEqual(false); expect(utils.isArrayBuffer({})).toEqual(false);