2
0
mirror of https://github.com/tenrok/axios.git synced 2026-05-15 11:59:42 +03:00

fix: wrap errors to improve async stack trace (#5987)

This commit is contained in:
Ilya Priven
2024-01-24 17:21:12 -05:00
committed by GitHub
parent 6d4c421ee1
commit 123f354b92
2 changed files with 91 additions and 8 deletions
+69 -7
View File
@@ -53,6 +53,9 @@ function toleranceRange(positive, negative) {
}
}
const nodeVersion = process.versions.node.split('.').map(v => parseInt(v, 10));
const nodeMajorVersion = nodeVersion[0];
var noop = ()=> {};
const LOCAL_SERVER_URL = 'http://localhost:4444';
@@ -446,6 +449,57 @@ describe('supports http with nodejs', function () {
});
});
it('should wrap HTTP errors and keep stack', function (done) {
if (nodeMajorVersion <= 12) {
this.skip(); // node 12 support for async stack traces appears lacking
return;
}
server = http.createServer(function (req, res) {
res.statusCode = 400;
res.end();
}).listen(4444, function () {
void assert.rejects(
async function findMeInStackTrace() {
await axios.head('http://localhost:4444/one')
},
function (err) {
assert.equal(err.name, 'AxiosError')
assert.equal(err.isAxiosError, true)
const matches = [...err.stack.matchAll(/findMeInStackTrace/g)]
assert.equal(matches.length, 1, err.stack)
return true;
}
).then(done).catch(done);
});
});
it('should wrap interceptor errors and keep stack', function (done) {
if (nodeMajorVersion <= 12) {
this.skip(); // node 12 support for async stack traces appears lacking
return;
}
const axiosInstance = axios.create();
axiosInstance.interceptors.request.use((res) => {
throw new Error('from request interceptor')
});
server = http.createServer(function (req, res) {
res.end();
}).listen(4444, function () {
void assert.rejects(
async function findMeInStackTrace() {
await axiosInstance.get('http://localhost:4444/one')
},
function (err) {
assert.equal(err.name, 'Error')
assert.equal(err.message, 'from request interceptor')
const matches = [...err.stack.matchAll(/findMeInStackTrace/g)]
assert.equal(matches.length, 1, err.stack)
return true;
}
).then(done).catch(done);
});
});
it('should preserve the HTTP verb on redirect', function (done) {
server = http.createServer(function (req, res) {
if (req.method.toLowerCase() !== "head") {
@@ -1384,13 +1438,21 @@ describe('supports http with nodejs', function () {
// call cancel() when the request has been sent, but a response has not been received
source.cancel('Operation has been canceled.');
}).listen(4444, function () {
axios.get('http://localhost:4444/', {
cancelToken: source.token
}).catch(function (thrown) {
assert.ok(thrown instanceof axios.Cancel, 'Promise must be rejected with a CanceledError object');
assert.equal(thrown.message, 'Operation has been canceled.');
done();
});
void assert.rejects(
async function findMeInStackTrace() {
await axios.get('http://localhost:4444/', {
cancelToken: source.token
});
},
function (thrown) {
assert.ok(thrown instanceof axios.Cancel, 'Promise must be rejected with a CanceledError object');
assert.equal(thrown.message, 'Operation has been canceled.');
if (nodeMajorVersion > 12) {
assert.match(thrown.stack, /findMeInStackTrace/);
}
return true;
},
).then(done).catch(done);
});
});