mirrors/OverlayScrollbars
2
0
Fork 0
mirror of https://github.com/tenrok/OverlayScrollbars.git synced 2026-06-17 02:30:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

add rounding issues on ff visualization

Browse Source
This commit is contained in:
Rene Haas
2022-07-08 10:58:58 +02:00
parent b581c91738
commit df45657e64
2 changed files with 39 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/overlayscrollbars/src/setups/structureSetup/updateSegments/overflowUpdateSegment.ts
+1 -1
View File
@@ -112,7 +112,7 @@ export const createOverflowUpdate: CreateStructureUpdateSegment = (
const [updateSizeFraction, getCurrentSizeFraction] = createCache<WH<number>>( const [updateSizeFraction, getCurrentSizeFraction] = createCache<WH<number>>(
whCacheOptions, whCacheOptions,
fractionalSize.bind(0, _host) fractionalSize.bind(0, _viewport)
); );
const [updateViewportScrollSizeCache, getCurrentViewportScrollSizeCache] = createCache< const [updateViewportScrollSizeCache, getCurrentViewportScrollSizeCache] = createCache<
packages/overlayscrollbars/tests/playwright/setups/structureSetup/update/index.browser.ts
+38 -10
View File
@@ -15,6 +15,7 @@ import {
removeAttr, removeAttr,
contents, contents,
appendChildren, appendChildren,
createDOM,
} from 'support'; } from 'support';
import { resize } from '@/testing-browser/Resize'; import { resize } from '@/testing-browser/Resize';
import { setTestResult, waitForOrFailTest } from '@/testing-browser/TestResult'; import { setTestResult, waitForOrFailTest } from '@/testing-browser/TestResult';
@@ -69,6 +70,7 @@ const expectedOverflowVisibleBehavior = (
// @ts-ignore // @ts-ignore
const msie11 = !!window.MSInputMethodContext && !!document.documentMode; const msie11 = !!window.MSInputMethodContext && !!document.documentMode;
const ff = navigator.userAgent.toLowerCase().indexOf('firefox') > -1;
const msedge = window.navigator.userAgent.toLowerCase().indexOf('edge') > -1; const msedge = window.navigator.userAgent.toLowerCase().indexOf('edge') > -1;
msie11 && addClass(document.body, 'msie11'); msie11 && addClass(document.body, 'msie11');
@@ -282,16 +284,42 @@ const checkMetrics = async (checkComparison: CheckComparisonObj) => {
// ==== check scroll values: // ==== check scroll values:
should.equal( if (ff && isFractionalPixelRatio()) {
targetMetrics.scroll.width, should.ok(
comparisonMetrics.scroll.width, Math.abs(targetMetrics.scroll.width - comparisonMetrics.scroll.width) <= 1,
`Scroll width equality. (${osInstance.state().overflowAmount.x})` `Scroll width equality. +-1 (${osInstance.state().overflowAmount.x})`
); );
should.equal( should.ok(
targetMetrics.scroll.height, Math.abs(targetMetrics.scroll.height - comparisonMetrics.scroll.height) <= 1,
comparisonMetrics.scroll.height, `Scroll height equality. +-1 (${osInstance.state().overflowAmount.y})`
`Scroll height equality. (${osInstance.state().overflowAmount.y})` );
);
if (!document.querySelector('#rounding')) {
appendChildren(
targetUpdatesSlot!.parentElement!.parentElement,
createDOM('<span>Rounding issues: <span id="rounding">0</span></span>')
);
}
const roundingElm = document.querySelector('#rounding');
const scrollWidth = targetMetrics.scroll.width - comparisonMetrics.scroll.width;
const scrollHeight = targetMetrics.scroll.height - comparisonMetrics.scroll.height;
if (scrollWidth !== 0 || scrollHeight !== 0) {
console.log(scrollWidth);
console.log(scrollHeight);
roundingElm!.textContent = `${(parseInt(roundingElm!.textContent || '0', 10) || 0) + 1}`;
}
} else {
should.equal(
targetMetrics.scroll.width,
comparisonMetrics.scroll.width,
`Scroll width equality. (${osInstance.state().overflowAmount.x})`
);
should.equal(
targetMetrics.scroll.height,
comparisonMetrics.scroll.height,
`Scroll height equality. (${osInstance.state().overflowAmount.y})`
);
}
should.equal( should.equal(
targetMetrics.hasOverflow.x, targetMetrics.hasOverflow.x,