mirrors/OverlayScrollbars
2
0
Fork 0
mirror of https://github.com/tenrok/OverlayScrollbars.git synced 2026-06-18 22:20:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix domobserver bug

Browse Source
This commit is contained in:
Rene
2021-04-18 16:08:02 +02:00
parent 9a9aea5bfe
commit c827cf8e7e
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/overlayscrollbars/src/observers/domObserver.ts
+9 -4
View File
@@ -222,8 +222,13 @@ export const createDOMObserver = <ContentObserver extends boolean>(
contentChanged = contentChanged || contentFinalChanged; contentChanged = contentChanged || contentFinalChanged;
childListChanged = childListChanged || isChildListType; childListChanged = childListChanged || isChildListType;
} }
// else if is target observer and target attr changed // if is target observer and target attr changed
else if (attributeChanged && !ignoreTargetChange(mutationTarget, attributeName!, oldValue, attributeValue as string | null)) { if (
!isContentObserver &&
targetIsMutationTarget &&
attributeChanged &&
!ignoreTargetChange(mutationTarget, attributeName!, oldValue, attributeValue as string | null)
) {
push(targetChangedAttrs, attributeName!); push(targetChangedAttrs, attributeName!);
targetStyleChanged = targetStyleChanged || styleChangingAttrChanged; targetStyleChanged = targetStyleChanged || styleChangingAttrChanged;
} }
@@ -239,8 +244,8 @@ export const createDOMObserver = <ContentObserver extends boolean>(
); );
} }
if (isContentObserver && contentChanged) { if (isContentObserver) {
(callback as DOMContentObserverCallback)(contentChanged); contentChanged && (callback as DOMContentObserverCallback)(contentChanged);
} else if (!isEmptyArray(targetChangedAttrs) || targetStyleChanged) { } else if (!isEmptyArray(targetChangedAttrs) || targetStyleChanged) {
(callback as DOMTargetObserverCallback)(targetChangedAttrs, targetStyleChanged); (callback as DOMTargetObserverCallback)(targetChangedAttrs, targetStyleChanged);
} }
packages/overlayscrollbars/tests/browser/observers/domObserver/index.browser.ts
+2
View File
@@ -438,6 +438,8 @@ const addRemoveImgElmsFn = async () => {
['img', 'something2'], ['img', 'something2'],
['img', null], ['img', null],
['img', undefined], ['img', undefined],
[null, null],
[undefined, undefined],
['img', () => 'hi'], ['img', () => 'hi'],
['img', () => null], ['img', () => null],
['img', () => undefined], ['img', () => undefined],