gopkg/service
2
0
Fork 0
Code Pull Requests Activity

Do not create windows services with an empty environment key (#343)

Browse Source 
Doing so will create services that are broken and will fail
when started:
`Error 87: The parameter is incorrect`

This is a regression from https://github.com/kardianos/service/pull/312
This commit is contained in:
Marco Pfatschbacher
2022-10-10 23:56:32 +02:00
committed by GitHub
parent 29f8c79c51
commit 6547573c4d
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
service_windows.go
+4
View File
@@ -241,6 +241,10 @@ func lowPrivSvc(m *mgr.Mgr, name string) (*mgr.Service, error) {
} }
func (ws *windowsService) setEnvironmentVariablesInRegistry() error { func (ws *windowsService) setEnvironmentVariablesInRegistry() error {
if len(ws.EnvVars) == 0 {
return nil
}
k, _, err := registry.CreateKey( k, _, err := registry.CreateKey(
registry.LOCAL_MACHINE, `SYSTEM\CurrentControlSet\Services\`+ws.Name, registry.LOCAL_MACHINE, `SYSTEM\CurrentControlSet\Services\`+ws.Name,
registry.QUERY_VALUE|registry.SET_VALUE|registry.CREATE_SUB_KEY) registry.QUERY_VALUE|registry.SET_VALUE|registry.CREATE_SUB_KEY)