gopkg/puddle
2
0
Fork 0
Code Activity

Improve test robustness

Browse Source
This commit is contained in:
Jack Christensen
2018-12-24 12:12:02 -06:00
parent 9ede55618e
commit b3026d0d8f
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pool_test.go
+6 -7
View File
@@ -194,11 +194,7 @@ func TestPoolReturnPanicsIfResourceNotPartOfPool(t *testing.T) {
func TestPoolReturnClosesAndRemovesResourceIfOlderThanMaxDuration(t *testing.T) { func TestPoolReturnClosesAndRemovesResourceIfOlderThanMaxDuration(t *testing.T) {
createFunc, _ := createCreateResourceFunc() createFunc, _ := createCreateResourceFunc()
var closeCalls Counter closeFunc, closeCalls, closeCallsChan := createCloseResourceFuncWithNotifierChan()
closeFunc := func(interface{}) error {
closeCalls.Next()
return nil
}
pool := puddle.NewPool(createFunc, closeFunc) pool := puddle.NewPool(createFunc, closeFunc)
@@ -206,11 +202,14 @@ func TestPoolReturnClosesAndRemovesResourceIfOlderThanMaxDuration(t *testing.T)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, 1, pool.Size()) assert.Equal(t, 1, pool.Size())
pool.SetMaxResourceDuration(time.Nanosecond)
time.Sleep(time.Nanosecond)
pool.SetMaxResourceDuration(time.Nanosecond)
time.Sleep(2 * time.Nanosecond)
pool.Return(res) pool.Return(res)
waitForRead(closeCallsChan)
assert.Equal(t, 0, pool.Size()) assert.Equal(t, 0, pool.Size())
assert.Equal(t, 1, closeCalls.Value())
} }
func TestPoolReturnClosesAndRemovesResourceIfMoreUsesThanMaxResourceUses(t *testing.T) { func TestPoolReturnClosesAndRemovesResourceIfMoreUsesThanMaxResourceUses(t *testing.T) {