gopkg/puddle
2
0
Fork 0
Code Activity

Code review changes

Browse Source
This commit is contained in:
Jan Dubsky
2022-10-10 15:00:48 +02:00
committed by Jack Christensen
parent 8663ac8d76
commit 30b91519a0
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
go.mod
+5 -2
View File
@@ -1,8 +1,11 @@
module github.com/jackc/puddle/v2 module github.com/jackc/puddle/v2
go 1.19 go 1.18
require github.com/stretchr/testify v1.8.0 require (
github.com/stretchr/testify v1.8.0
go.uber.org/atomic v1.10.0
)
require ( require (
github.com/davecgh/go-spew v1.1.1 // indirect github.com/davecgh/go-spew v1.1.1 // indirect
go.sum
+2
View File
@@ -8,6 +8,8 @@ github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSS
github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
github.com/stretchr/testify v1.8.0 h1:pSgiaMZlXftHpm5L7V1+rVB+AZJydKsMxsQBIJw4PKk= github.com/stretchr/testify v1.8.0 h1:pSgiaMZlXftHpm5L7V1+rVB+AZJydKsMxsQBIJw4PKk=
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU= github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
go.uber.org/atomic v1.10.0 h1:9qC72Qh0+3MqyJbAn8YU5xVq1frD8bn3JtD2oXtafVQ=
go.uber.org/atomic v1.10.0/go.mod h1:LUxbIzbOniOlMKjJjyPfpl4v+PKK2cNJn91OQbhoJI0=
golang.org/x/sync v0.0.0-20220923202941-7f9b1623fab7 h1:ZrnxWX62AgTKOSagEqxvb3ffipvEDX2pl7E1TdqLqIc= golang.org/x/sync v0.0.0-20220923202941-7f9b1623fab7 h1:ZrnxWX62AgTKOSagEqxvb3ffipvEDX2pl7E1TdqLqIc=
golang.org/x/sync v0.0.0-20220923202941-7f9b1623fab7/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM= golang.org/x/sync v0.0.0-20220923202941-7f9b1623fab7/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
pool.go
+3 -1
View File
@@ -4,10 +4,10 @@ import (
"context" "context"
"errors" "errors"
"sync" "sync"
"sync/atomic"
"time" "time"
"github.com/jackc/puddle/v2/internal/circ" "github.com/jackc/puddle/v2/internal/circ"
"go.uber.org/atomic"
"golang.org/x/sync/semaphore" "golang.org/x/sync/semaphore"
) )
@@ -365,6 +365,7 @@ func (p *Pool[T]) acquire(ctx context.Context) (*Resource[T], error) {
if len(p.allResources) >= int(p.maxSize) { if len(p.allResources) >= int(p.maxSize) {
p.mux.Unlock() p.mux.Unlock()
p.acquireSem.Release(1) p.acquireSem.Release(1)
// Unreachable code.
panic("bug: semaphore allowed more acquires than pool allows") panic("bug: semaphore allowed more acquires than pool allows")
} }
@@ -449,6 +450,7 @@ func (p *Pool[T]) TryAcquire(ctx context.Context) (*Resource[T], error) {
} }
if len(p.allResources) >= int(p.maxSize) { if len(p.allResources) >= int(p.maxSize) {
// Unreachable code.
panic("bug: semaphore allowed more acquires than pool allows") panic("bug: semaphore allowed more acquires than pool allows")
} }