gopkg/pgx
2
0
Fork 0
Code Activity

Reuse buffer for writing

Browse Source
This commit is contained in:
Jack Christensen
2019-04-18 21:51:58 -05:00
parent 0174907e04
commit e948dc3246
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pgconn.go
+11 -8
View File
@@ -97,6 +97,8 @@ type PgConn struct {
bufferingReceiveMux sync.Mutex bufferingReceiveMux sync.Mutex
bufferingReceiveMsg pgproto3.BackendMessage bufferingReceiveMsg pgproto3.BackendMessage
bufferingReceiveErr error bufferingReceiveErr error
wbuf []byte // Reusable write buffer
} }
// Connect establishes a connection to a PostgreSQL server using the environment and connString (in URL or DSN format) // Connect establishes a connection to a PostgreSQL server using the environment and connString (in URL or DSN format)
@@ -153,6 +155,7 @@ func ConnectConfig(ctx context.Context, config *Config) (pgConn *PgConn, err err
func connect(ctx context.Context, config *Config, fallbackConfig *FallbackConfig) (*PgConn, error) { func connect(ctx context.Context, config *Config, fallbackConfig *FallbackConfig) (*PgConn, error) {
pgConn := new(PgConn) pgConn := new(PgConn)
pgConn.Config = config pgConn.Config = config
pgConn.wbuf = make([]byte, 0, 1024)
var err error var err error
network, address := NetworkAddress(fallbackConfig.Host, fallbackConfig.Port) network, address := NetworkAddress(fallbackConfig.Host, fallbackConfig.Port)
@@ -190,7 +193,7 @@ func connect(ctx context.Context, config *Config, fallbackConfig *FallbackConfig
startupMsg.Parameters["database"] = config.Database startupMsg.Parameters["database"] = config.Database
} }
if _, err := pgConn.conn.Write(startupMsg.Encode(nil)); err != nil { if _, err := pgConn.conn.Write(startupMsg.Encode(pgConn.wbuf)); err != nil {
pgConn.conn.Close() pgConn.conn.Close()
return nil, err return nil, err
} }
@@ -271,7 +274,7 @@ func (c *PgConn) rxAuthenticationX(msg *pgproto3.Authentication) (err error) {
func (pgConn *PgConn) txPasswordMessage(password string) (err error) { func (pgConn *PgConn) txPasswordMessage(password string) (err error) {
msg := &pgproto3.PasswordMessage{Password: password} msg := &pgproto3.PasswordMessage{Password: password}
_, err = pgConn.conn.Write(msg.Encode(nil)) _, err = pgConn.conn.Write(msg.Encode(pgConn.wbuf))
return err return err
} }
@@ -513,7 +516,7 @@ func (pgConn *PgConn) Prepare(ctx context.Context, name, sql string, paramOIDs [
cleanupContextDeadline := contextDoneToConnDeadline(ctx, pgConn.conn) cleanupContextDeadline := contextDoneToConnDeadline(ctx, pgConn.conn)
defer cleanupContextDeadline() defer cleanupContextDeadline()
var buf []byte buf := pgConn.wbuf
buf = (&pgproto3.Parse{Name: name, Query: sql, ParameterOIDs: paramOIDs}).Encode(buf) buf = (&pgproto3.Parse{Name: name, Query: sql, ParameterOIDs: paramOIDs}).Encode(buf)
buf = (&pgproto3.Describe{ObjectType: 'S', Name: name}).Encode(buf) buf = (&pgproto3.Describe{ObjectType: 'S', Name: name}).Encode(buf)
buf = (&pgproto3.Sync{}).Encode(buf) buf = (&pgproto3.Sync{}).Encode(buf)
@@ -676,7 +679,7 @@ func (pgConn *PgConn) Exec(ctx context.Context, sql string) *MultiResultReader {
} }
multiResult.cleanupContextDeadline = contextDoneToConnDeadline(ctx, pgConn.conn) multiResult.cleanupContextDeadline = contextDoneToConnDeadline(ctx, pgConn.conn)
var buf []byte buf := pgConn.wbuf
buf = (&pgproto3.Query{String: sql}).Encode(buf) buf = (&pgproto3.Query{String: sql}).Encode(buf)
_, err := pgConn.conn.Write(buf) _, err := pgConn.conn.Write(buf)
@@ -717,7 +720,7 @@ func (pgConn *PgConn) ExecParams(ctx context.Context, sql string, paramValues []
return result return result
} }
var buf []byte buf := pgConn.wbuf
buf = (&pgproto3.Parse{Query: sql, ParameterOIDs: paramOIDs}).Encode(buf) buf = (&pgproto3.Parse{Query: sql, ParameterOIDs: paramOIDs}).Encode(buf)
buf = (&pgproto3.Bind{ParameterFormatCodes: paramFormats, Parameters: paramValues, ResultFormatCodes: resultFormats}).Encode(buf) buf = (&pgproto3.Bind{ParameterFormatCodes: paramFormats, Parameters: paramValues, ResultFormatCodes: resultFormats}).Encode(buf)
@@ -744,7 +747,7 @@ func (pgConn *PgConn) ExecPrepared(ctx context.Context, stmtName string, paramVa
return result return result
} }
var buf []byte buf := pgConn.wbuf
buf = (&pgproto3.Bind{PreparedStatement: stmtName, ParameterFormatCodes: paramFormats, Parameters: paramValues, ResultFormatCodes: resultFormats}).Encode(buf) buf = (&pgproto3.Bind{PreparedStatement: stmtName, ParameterFormatCodes: paramFormats, Parameters: paramValues, ResultFormatCodes: resultFormats}).Encode(buf)
pgConn.execExtendedSuffix(buf, result) pgConn.execExtendedSuffix(buf, result)
@@ -816,7 +819,7 @@ func (pgConn *PgConn) CopyTo(ctx context.Context, w io.Writer, sql string) (Comm
defer cleanupContextDeadline() defer cleanupContextDeadline()
// Send copy to command // Send copy to command
var buf []byte buf := pgConn.wbuf
buf = (&pgproto3.Query{String: sql}).Encode(buf) buf = (&pgproto3.Query{String: sql}).Encode(buf)
_, err := pgConn.conn.Write(buf) _, err := pgConn.conn.Write(buf)
@@ -875,7 +878,7 @@ func (pgConn *PgConn) CopyFrom(ctx context.Context, r io.Reader, sql string) (Co
defer cleanupContextDeadline() defer cleanupContextDeadline()
// Send copy to command // Send copy to command
var buf []byte buf := pgConn.wbuf
buf = (&pgproto3.Query{String: sql}).Encode(buf) buf = (&pgproto3.Query{String: sql}).Encode(buf)
_, err := pgConn.conn.Write(buf) _, err := pgConn.conn.Write(buf)