2
0

Privatize Conn.SecretKey

This commit is contained in:
Jack Christensen
2017-02-16 18:26:24 -06:00
parent e390ac33f5
commit ccc65c361a
3 changed files with 6 additions and 8 deletions
+3 -1
View File
@@ -18,6 +18,8 @@ Transaction isolation level constants are now typed strings instead of bare stri
Conn.Pid changed to accessor method Conn.PID()
Conn.SecretKey removed
Remove Conn.TxStatus
Added Context methods
@@ -50,7 +52,7 @@ dValueReader / msgReader cleanup
Make easier / possible to mock Conn or ConnPool (https://github.com/jackc/pgx/pull/162)
Every field that should not be set by user should be replaced by accessor method (e.g. Conn.PID, Conn.SecretKey)
Every field that should not be set by user should be replaced by accessor method (only ones left are Conn.RuntimeParams and Conn.PgTypes)
Investigate strongly typed queries. i.e. Some sort of interface where varargs of Query, Exec, and Scan wouldn't happen. Need to be some low-level interface where (probably generated) functions could (more or less) directly read and write to the connection. Clean code and type-safety / control would be the benefits. Row scanning performance is already so fast there is little to improve (go_db_bench shows under 1 microsecond per row).