gopkg/pgx
2
0
Fork 0
Code Activity

Fix leaked contexts

Browse Source
This commit is contained in:
Jack Christensen
2017-02-16 18:11:30 -06:00
parent efcc172c8b
commit c540b65edf
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
replication.go
+2 -1
View File
@@ -377,7 +377,8 @@ func (rc *ReplicationConn) StartReplication(slotName string, startLsn uint64, ti
return return
} }
ctx, _ := context.WithTimeout(context.Background(), initialReplicationResponseTimeout) ctx, cancelFn := context.WithTimeout(context.Background(), initialReplicationResponseTimeout)
defer cancelFn()
// The first replication message that comes back here will be (in a success case) // The first replication message that comes back here will be (in a success case)
// a empty CopyBoth that is (apparently) sent as the confirmation that the replication has // a empty CopyBoth that is (apparently) sent as the confirmation that the replication has
replication_test.go
+2 -1
View File
@@ -89,7 +89,8 @@ func TestSimpleReplicationConnection(t *testing.T) {
for { for {
var message *pgx.ReplicationMessage var message *pgx.ReplicationMessage
ctx, _ := context.WithTimeout(context.Background(), time.Second) ctx, cancelFn := context.WithTimeout(context.Background(), time.Second)
defer cancelFn()
message, err = replicationConn.WaitForReplicationMessage(ctx) message, err = replicationConn.WaitForReplicationMessage(ctx)
if err != nil && err != context.DeadlineExceeded { if err != nil && err != context.DeadlineExceeded {
t.Fatalf("Replication failed: %v %s", err, reflect.TypeOf(err)) t.Fatalf("Replication failed: %v %s", err, reflect.TypeOf(err))