gopkg/pgx
2
0
Fork 0
Code Activity

Reduce big read buffer allocations with sync.Pool

Browse Source
This commit is contained in:
Jack Christensen
2022-02-26 19:57:41 -06:00
parent 2fad63c189
commit b1e4b96e6c
2 changed files with 83 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pgproto3/chunkreader_test.go
+9 -3
View File
@@ -32,6 +32,12 @@ func TestChunkReaderNextDoesNotReadIfAlreadyBuffered(t *testing.T) {
if bytes.Compare(r.buf, src) != 0 {
t.Fatalf("Expected r.buf to be %v, but it was %v", src, r.buf)
}
_, err = r.Next(0) // Trigger the buffer reset.
if err != nil {
t.Fatal(err)
}
if r.rp != 0 {
t.Fatalf("Expected r.rp to be %v, but it was %v", 0, r.rp)
}
@@ -40,7 +46,7 @@ func TestChunkReaderNextDoesNotReadIfAlreadyBuffered(t *testing.T) {
}
}
func TestChunkReaderNextExpandsBufAsNeeded(t *testing.T) {
func TestChunkReaderNextGetsBiggerBufAsNeededFromBigBufPools(t *testing.T) {
server := &bytes.Buffer{}
r := newChunkReader(server, 4)
@@ -54,8 +60,8 @@ func TestChunkReaderNextExpandsBufAsNeeded(t *testing.T) {
if bytes.Compare(n1, src[0:5]) != 0 {
t.Fatalf("Expected read bytes to be %v, but they were %v", src[0:5], n1)
}
if len(r.buf) != 4 {
t.Fatalf("Expected len(r.buf) to be %v, but it was %v", 4, len(r.buf))
if len(r.buf) != bigBufPools[0].byteSize {
t.Fatalf("Expected len(r.buf) to be %v, but it was %v", bigBufPools[0].byteSize, len(r.buf))
}
}