gopkg/pgx
2
0
Fork 0
Code Activity

Value, EncodeBinary, EncodeText, and MarshalJSON on T instead of *T

Browse Source 
Methods defined on T are also available on *T. This change makes Value
consistent with database/sql Value implementations. It also makes Value,
EncodeBinary, and EncodeText more convenient to use because you can
pass T or *T as an argument to a query.

The MarshalJSON change is even more significant because without it
json.Marshal would generate the "%v" format instead of the implemented
MarshalJSON.

Thought this technically changes the interface, because *T will be
automatically dereferenced as needed it shouldn't be a breaking change.

See: https://github.com/jackc/pgx/issues/538 for initial discussion.
This commit is contained in:
Jack Christensen
2019-08-27 20:46:16 -05:00
parent b1e25e4ea4
commit a8802b16cc
66 changed files with 222 additions and 222 deletions
Download Patch File Download Diff File Expand all files Collapse all files
path.go
+3 -3
View File
@@ -116,7 +116,7 @@ func (dst *Path) DecodeBinary(ci *ConnInfo, src []byte) error {
return nil
}
func (src *Path) EncodeText(ci *ConnInfo, buf []byte) ([]byte, error) {
func (src Path) EncodeText(ci *ConnInfo, buf []byte) ([]byte, error) {
switch src.Status {
case Null:
return nil, nil
@@ -147,7 +147,7 @@ func (src *Path) EncodeText(ci *ConnInfo, buf []byte) ([]byte, error) {
return append(buf, endByte), nil
}
func (src *Path) EncodeBinary(ci *ConnInfo, buf []byte) ([]byte, error) {
func (src Path) EncodeBinary(ci *ConnInfo, buf []byte) ([]byte, error) {
switch src.Status {
case Null:
return nil, nil
@@ -191,6 +191,6 @@ func (dst *Path) Scan(src interface{}) error {
}
// Value implements the database/sql/driver Valuer interface.
func (src *Path) Value() (driver.Value, error) {
func (src Path) Value() (driver.Value, error) {
return EncodeValueText(src)
}