gopkg/pgx
2
0
Fork 0
Code Activity

Value, EncodeBinary, EncodeText, and MarshalJSON on T instead of *T

Browse Source 
Methods defined on T are also available on *T. This change makes Value
consistent with database/sql Value implementations. It also makes Value,
EncodeBinary, and EncodeText more convenient to use because you can
pass T or *T as an argument to a query.

The MarshalJSON change is even more significant because without it
json.Marshal would generate the "%v" format instead of the implemented
MarshalJSON.

Thought this technically changes the interface, because *T will be
automatically dereferenced as needed it shouldn't be a breaking change.

See: https://github.com/jackc/pgx/issues/538 for initial discussion.
This commit is contained in:
Jack Christensen
2019-08-27 20:46:16 -05:00
parent b1e25e4ea4
commit a8802b16cc
66 changed files with 222 additions and 222 deletions
Download Patch File Download Diff File Expand all files Collapse all files
numeric.go
+3 -3
View File
@@ -455,7 +455,7 @@ func nbaseDigitsToInt64(src []byte) (accum int64, bytesRead, digitsRead int) {
return accum, rp, digits
}
func (src *Numeric) EncodeText(ci *ConnInfo, buf []byte) ([]byte, error) {
func (src Numeric) EncodeText(ci *ConnInfo, buf []byte) ([]byte, error) {
switch src.Status {
case Null:
return nil, nil
@@ -469,7 +469,7 @@ func (src *Numeric) EncodeText(ci *ConnInfo, buf []byte) ([]byte, error) {
return buf, nil
}
func (src *Numeric) EncodeBinary(ci *ConnInfo, buf []byte) ([]byte, error) {
func (src Numeric) EncodeBinary(ci *ConnInfo, buf []byte) ([]byte, error) {
switch src.Status {
case Null:
return nil, nil
@@ -580,7 +580,7 @@ func (dst *Numeric) Scan(src interface{}) error {
}
// Value implements the database/sql/driver Valuer interface.
func (src *Numeric) Value() (driver.Value, error) {
func (src Numeric) Value() (driver.Value, error) {
switch src.Status {
case Present:
buf, err := src.EncodeText(nil, nil)