2
0

Convert large objects to prepared statements

This allows removing semi-obsolete fastpath interface support. See
https://www.postgresql.org/docs/current/libpq-fastpath.html. This also
simplifies introducing context support.
This commit is contained in:
Jack Christensen
2019-05-11 11:36:38 -05:00
parent f572b336b1
commit 79f49ce300
4 changed files with 97 additions and 181 deletions
+3 -14
View File
@@ -11,7 +11,6 @@ import (
)
func TestLargeObjects(t *testing.T) {
t.Skip("TODO: fix or (re)move")
t.Parallel()
conn, err := pgx.Connect(context.Background(), os.Getenv("PGX_TEST_DATABASE"))
@@ -24,10 +23,7 @@ func TestLargeObjects(t *testing.T) {
t.Fatal(err)
}
lo, err := tx.LargeObjects()
if err != nil {
t.Fatal(err)
}
lo := tx.LargeObjects()
id, err := lo.Create(0)
if err != nil {
@@ -125,7 +121,6 @@ func TestLargeObjects(t *testing.T) {
}
func TestLargeObjectsMultipleTransactions(t *testing.T) {
t.Skip("TODO: fix or (re)move")
t.Parallel()
conn, err := pgx.Connect(context.Background(), os.Getenv("PGX_TEST_DATABASE"))
@@ -138,10 +133,7 @@ func TestLargeObjectsMultipleTransactions(t *testing.T) {
t.Fatal(err)
}
lo, err := tx.LargeObjects()
if err != nil {
t.Fatal(err)
}
lo := tx.LargeObjects()
id, err := lo.Create(0)
if err != nil {
@@ -181,10 +173,7 @@ func TestLargeObjectsMultipleTransactions(t *testing.T) {
t.Fatal(err)
}
lo2, err := tx2.LargeObjects()
if err != nil {
t.Fatal(err)
}
lo2 := tx2.LargeObjects()
// Reopen the large object in the new transaction
obj2, err := lo2.Open(id, pgx.LargeObjectModeRead|pgx.LargeObjectModeWrite)