gopkg/pgx
2
0
Fork 0
Code Activity

Fix tests for iobufpool optimization

Browse Source
This commit is contained in:
Jack Christensen
2023-01-28 09:30:12 -06:00
parent eee854fb06
commit 7019ed1edf
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/iobufpool/iobufpool_test.go
+7 -7
View File
@@ -30,15 +30,15 @@ func TestGetCap(t *testing.T) {
} }
for _, tt := range tests { for _, tt := range tests {
buf := iobufpool.Get(tt.requestedLen) buf := iobufpool.Get(tt.requestedLen)
assert.Equalf(t, tt.requestedLen, len(buf), "bad len for requestedLen: %d", len(buf), tt.requestedLen) assert.Equalf(t, tt.requestedLen, len(*buf), "bad len for requestedLen: %d", len(*buf), tt.requestedLen)
assert.Equalf(t, tt.expectedCap, cap(buf), "bad cap for requestedLen: %d", tt.requestedLen) assert.Equalf(t, tt.expectedCap, cap(*buf), "bad cap for requestedLen: %d", tt.requestedLen)
} }
} }
func TestPutHandlesWrongSizedBuffers(t *testing.T) { func TestPutHandlesWrongSizedBuffers(t *testing.T) {
for putBufSize := range []int{0, 1, 128, 250, 256, 257, 1023, 1024, 1025, 1 << 28} { for putBufSize := range []int{0, 1, 128, 250, 256, 257, 1023, 1024, 1025, 1 << 28} {
putBuf := make([]byte, putBufSize) putBuf := make([]byte, putBufSize)
iobufpool.Put(putBuf) iobufpool.Put(&putBuf)
tests := []struct { tests := []struct {
requestedLen int requestedLen int
@@ -62,8 +62,8 @@ func TestPutHandlesWrongSizedBuffers(t *testing.T) {
} }
for _, tt := range tests { for _, tt := range tests {
getBuf := iobufpool.Get(tt.requestedLen) getBuf := iobufpool.Get(tt.requestedLen)
assert.Equalf(t, tt.requestedLen, len(getBuf), "len(putBuf): %d, requestedLen: %d", len(putBuf), tt.requestedLen) assert.Equalf(t, tt.requestedLen, len(*getBuf), "len(putBuf): %d, requestedLen: %d", len(putBuf), tt.requestedLen)
assert.Equalf(t, tt.expectedCap, cap(getBuf), "cap(putBuf): %d, requestedLen: %d", cap(putBuf), tt.requestedLen) assert.Equalf(t, tt.expectedCap, cap(*getBuf), "cap(putBuf): %d, requestedLen: %d", cap(putBuf), tt.requestedLen)
} }
} }
} }
@@ -73,10 +73,10 @@ func TestPutGetBufferReuse(t *testing.T) {
// it not to be. So try many times. // it not to be. So try many times.
for i := 0; i < 100000; i++ { for i := 0; i < 100000; i++ {
buf := iobufpool.Get(4) buf := iobufpool.Get(4)
buf[0] = 1 (*buf)[0] = 1
iobufpool.Put(buf) iobufpool.Put(buf)
buf = iobufpool.Get(4) buf = iobufpool.Get(4)
if buf[0] == 1 { if (*buf)[0] == 1 {
return return
} }
} }
pgproto3/chunkreader_test.go
+1 -1
View File
@@ -29,7 +29,7 @@ func TestChunkReaderNextDoesNotReadIfAlreadyBuffered(t *testing.T) {
t.Fatalf("Expected read bytes to be %v, but they were %v", src[2:4], n2) t.Fatalf("Expected read bytes to be %v, but they were %v", src[2:4], n2)
} }
if bytes.Compare(r.buf[:len(src)], src) != 0 { if bytes.Compare((*r.buf)[:len(src)], src) != 0 {
t.Fatalf("Expected r.buf to be %v, but it was %v", src, r.buf) t.Fatalf("Expected r.buf to be %v, but it was %v", src, r.buf)
} }