gopkg/pgx
2
0
Fork 0
Code Activity

Prevent every row scan from causing a malloc

Browse Source
This commit is contained in:
Jack Christensen
2016-04-30 12:54:16 -05:00
parent e3859aa03e
commit 6e2cee6294
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
query.go
+6 -1
View File
@@ -301,7 +301,12 @@ func (rows *Rows) Scan(dest ...interface{}) (err error) {
rows.Fatal(scanArgError{col: i, err: err}) rows.Fatal(scanArgError{col: i, err: err})
} }
} else if vr.Type().DataType == JsonOid || vr.Type().DataType == JsonbOid { } else if vr.Type().DataType == JsonOid || vr.Type().DataType == JsonbOid {
decodeJSON(vr, &d) // Because the argument passed to decodeJSON will escape the heap.
// This allows d to be stack allocated and only copied to the heap when
// we actually are decoding JSON. This saves one memory allocation per
// row.
d2 := d
decodeJSON(vr, &d2)
} else { } else {
if err := Decode(vr, d); err != nil { if err := Decode(vr, d); err != nil {
rows.Fatal(scanArgError{col: i, err: err}) rows.Fatal(scanArgError{col: i, err: err})