From 698bd4bf5a75e4c6386e38225e701d7a08da4c86 Mon Sep 17 00:00:00 2001 From: Jack Christensen Date: Sat, 13 Apr 2019 10:30:49 -0500 Subject: [PATCH] Use defer to unlock pgConn in Prepare --- pgconn.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pgconn.go b/pgconn.go index 7ddc50e6..c9891dbf 100644 --- a/pgconn.go +++ b/pgconn.go @@ -501,10 +501,10 @@ func (pgConn *PgConn) Prepare(ctx context.Context, name, sql string, paramOIDs [ if err := pgConn.lock(); err != nil { return nil, err } + defer pgConn.unlock() select { case <-ctx.Done(): - pgConn.unlock() return nil, ctx.Err() default: } @@ -548,8 +548,6 @@ readloop: } } - pgConn.unlock() - if parseErr != nil { return nil, parseErr }