From 682201a4fcd72d5f688c511de165db7bf2227b3a Mon Sep 17 00:00:00 2001 From: Jack Christensen Date: Tue, 12 May 2020 10:26:51 -0500 Subject: [PATCH] Rename CloneTypeValue to NewTypeValue --- array_type.go | 2 +- enum_type.go | 2 +- pgtype.go | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/array_type.go b/array_type.go index f25051d1..4fe772fd 100644 --- a/array_type.go +++ b/array_type.go @@ -25,7 +25,7 @@ func NewArrayType(typeName string, newElement func() ValueTranscoder) *ArrayType return &ArrayType{typeName: typeName, newElement: newElement} } -func (at *ArrayType) CloneTypeValue() Value { +func (at *ArrayType) NewTypeValue() Value { return &ArrayType{ elements: at.elements, dimensions: at.dimensions, diff --git a/enum_type.go b/enum_type.go index 1a6a4b46..231c21fd 100644 --- a/enum_type.go +++ b/enum_type.go @@ -31,7 +31,7 @@ func NewEnumType(typeName string, members []string) EnumType { return et } -func (et *enumType) CloneTypeValue() Value { +func (et *enumType) NewTypeValue() Value { return &enumType{ value: et.value, status: et.status, diff --git a/pgtype.go b/pgtype.go index 25f1a1d5..6a703994 100644 --- a/pgtype.go +++ b/pgtype.go @@ -134,9 +134,9 @@ type Value interface { // In general, instances of TypeValue should not be used to directly represent a value. It should only be used as an // encoder and decoder internal to ConnInfo. type TypeValue interface { - // CloneTypeValue duplicates a TypeValue including references to internal type information. e.g. the list of members + // NewTypeValue creates a TypeValue including references to internal type information. e.g. the list of members // in an EnumType. - CloneTypeValue() Value + NewTypeValue() Value // TypeName returns the PostgreSQL name of this type. TypeName() string @@ -359,7 +359,7 @@ func (ci *ConnInfo) InitializeDataTypes(nameOIDs map[string]uint32) { func (ci *ConnInfo) RegisterDataType(t DataType) { if tv, ok := t.Value.(TypeValue); ok { - t.Value = tv.CloneTypeValue() + t.Value = tv.NewTypeValue() } ci.oidToDataType[t.OID] = &t @@ -469,7 +469,7 @@ func (ci *ConnInfo) DeepCopy() *ConnInfo { for _, dt := range ci.oidToDataType { var value Value if tv, ok := dt.Value.(TypeValue); ok { - value = tv.CloneTypeValue() + value = tv.NewTypeValue() } else { value = reflect.New(reflect.ValueOf(dt.Value).Elem().Type()).Interface().(Value) }