2
0

support for inserting []time.Time into timestamp[] columns

This commit is contained in:
Karl Seguin
2014-12-21 13:35:39 +07:00
parent d1b42d1c8e
commit 67292290cf
3 changed files with 66 additions and 22 deletions
+3 -1
View File
@@ -549,7 +549,7 @@ func (c *Conn) sendPreparedQuery(ps *PreparedStatement, arguments ...interface{}
wbuf.WriteInt16(TextFormatCode) wbuf.WriteInt16(TextFormatCode)
default: default:
switch oid { switch oid {
case BoolOid, ByteaOid, Int2Oid, Int4Oid, Int8Oid, Float4Oid, Float8Oid, TimestampTzOid, BoolArrayOid, Int2ArrayOid, Int4ArrayOid, Int8ArrayOid, Float4ArrayOid, Float8ArrayOid, TextArrayOid, VarcharArrayOid, OidOid: case BoolOid, ByteaOid, Int2Oid, Int4Oid, Int8Oid, Float4Oid, Float8Oid, TimestampTzOid, TimestampArrayOid, BoolArrayOid, Int2ArrayOid, Int4ArrayOid, Int8ArrayOid, Float4ArrayOid, Float8ArrayOid, TextArrayOid, VarcharArrayOid, OidOid:
wbuf.WriteInt16(BinaryFormatCode) wbuf.WriteInt16(BinaryFormatCode)
default: default:
wbuf.WriteInt16(TextFormatCode) wbuf.WriteInt16(TextFormatCode)
@@ -609,6 +609,8 @@ func (c *Conn) sendPreparedQuery(ps *PreparedStatement, arguments ...interface{}
err = encodeTextArray(wbuf, arguments[i], TextOid) err = encodeTextArray(wbuf, arguments[i], TextOid)
case VarcharArrayOid: case VarcharArrayOid:
err = encodeTextArray(wbuf, arguments[i], VarcharOid) err = encodeTextArray(wbuf, arguments[i], VarcharOid)
case TimestampArrayOid:
err = encodeTimestampArray(wbuf, arguments[i], VarcharOid)
case OidOid: case OidOid:
err = encodeOid(wbuf, arguments[i]) err = encodeOid(wbuf, arguments[i])
default: default:
+16
View File
@@ -531,3 +531,19 @@ func TestInsertBoolArray(t *testing.T) {
t.Errorf("Unexpected results from Exec: %v", results) t.Errorf("Unexpected results from Exec: %v", results)
} }
} }
func TestInsertTimestampArray(t *testing.T) {
t.Parallel()
conn := mustConnect(t, *defaultConnConfig)
defer closeConn(t, conn)
if results := mustExec(t, conn, "create temporary table foo(spice timestamp[]);"); results != "CREATE TABLE" {
t.Error("Unexpected results from Exec")
}
// Accept parameters
if results := mustExec(t, conn, "insert into foo(spice) values($1)", []time.Time{time.Unix(1419143667, 0), time.Unix(1419143672, 0)}); results != "INSERT 0 1" {
t.Errorf("Unexpected results from Exec: %v", results)
}
}
+26
View File
@@ -32,6 +32,7 @@ const (
VarcharOid = 1043 VarcharOid = 1043
DateOid = 1082 DateOid = 1082
TimestampOid = 1114 TimestampOid = 1114
TimestampArrayOid = 1115
TimestampTzOid = 1184 TimestampTzOid = 1184
) )
@@ -1597,3 +1598,28 @@ func encodeTextArray(w *WriteBuf, value interface{}, elOid Oid) error {
return nil return nil
} }
func encodeTimestampArray(w *WriteBuf, value interface{}, elOid Oid) error {
slice, ok := value.([]time.Time)
if !ok {
return fmt.Errorf("Expected []time.Time, received %T", value)
}
size := 20 + len(slice)*12
w.WriteInt32(int32(size))
w.WriteInt32(1) // number of dimensions
w.WriteInt32(0) // no nulls
w.WriteInt32(int32(TimestampOid)) // type of elements
w.WriteInt32(int32(len(slice))) // number of elements
w.WriteInt32(1) // index of first element
for _, t := range slice {
w.WriteInt32(8)
microsecSinceUnixEpoch := t.Unix()*1000000 + int64(t.Nanosecond())/1000
microsecSinceY2K := microsecSinceUnixEpoch - microsecFromUnixEpochToY2K
w.WriteInt64(microsecSinceY2K)
}
return nil
}