Add multidimensional array and slice support.
Adds array support - previously only slices were supported. Adds new test cases for multidimensional arrays and slices. All previous test cases are unmodified and passed (fully backwards compatible). Removes hard-coded type conversions for arrays, instead now relies on the type support of the array element's type conversion support. Less maintenance for arrays, new type conversions are automatically supported when array's element gains new type support. Simplifies typed_array_gen.sh generator script by removing the hard-coded single-dimensional types for arrays. Only typed_array.go.erb and typed_array_gen.sh have been changed + 1 new auxiliary function in array.go file + additional tests in test files for each array. Other changes are from generated code.
This commit is contained in:
Simo Haasanen
@@ -67,6 +67,54 @@ func TestEnumArrayArraySet(t *testing.T) {
|
||||
source: (([]string)(nil)),
|
||||
result: pgtype.EnumArray{Status: pgtype.Null},
|
||||
},
|
||||
{
|
||||
source: [][]string{{"foo"}, {"bar"}},
|
||||
result: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
||||
Status: pgtype.Present},
|
||||
},
|
||||
{
|
||||
source: [][][][]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
||||
result: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{
|
||||
{String: "foo", Status: pgtype.Present},
|
||||
{String: "bar", Status: pgtype.Present},
|
||||
{String: "baz", Status: pgtype.Present},
|
||||
{String: "wibble", Status: pgtype.Present},
|
||||
{String: "wobble", Status: pgtype.Present},
|
||||
{String: "wubble", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{
|
||||
{LowerBound: 1, Length: 2},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 3}},
|
||||
Status: pgtype.Present},
|
||||
},
|
||||
{
|
||||
source: [2][1]string{{"foo"}, {"bar"}},
|
||||
result: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
||||
Status: pgtype.Present},
|
||||
},
|
||||
{
|
||||
source: [2][1][1][3]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
||||
result: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{
|
||||
{String: "foo", Status: pgtype.Present},
|
||||
{String: "bar", Status: pgtype.Present},
|
||||
{String: "baz", Status: pgtype.Present},
|
||||
{String: "wibble", Status: pgtype.Present},
|
||||
{String: "wobble", Status: pgtype.Present},
|
||||
{String: "wubble", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{
|
||||
{LowerBound: 1, Length: 2},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 3}},
|
||||
Status: pgtype.Present},
|
||||
},
|
||||
}
|
||||
|
||||
for i, tt := range successfulTests {
|
||||
@@ -86,6 +134,10 @@ func TestEnumArrayArrayAssignTo(t *testing.T) {
|
||||
var stringSlice []string
|
||||
type _stringSlice []string
|
||||
var namedStringSlice _stringSlice
|
||||
var stringSliceDim2 [][]string
|
||||
var stringSliceDim4 [][][][]string
|
||||
var stringArrayDim2 [2][1]string
|
||||
var stringArrayDim4 [2][1][1][3]string
|
||||
|
||||
simpleTests := []struct {
|
||||
src pgtype.EnumArray
|
||||
@@ -115,6 +167,58 @@ func TestEnumArrayArrayAssignTo(t *testing.T) {
|
||||
dst: &stringSlice,
|
||||
expected: (([]string)(nil)),
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringSliceDim2,
|
||||
expected: [][]string{{"foo"}, {"bar"}},
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{
|
||||
{String: "foo", Status: pgtype.Present},
|
||||
{String: "bar", Status: pgtype.Present},
|
||||
{String: "baz", Status: pgtype.Present},
|
||||
{String: "wibble", Status: pgtype.Present},
|
||||
{String: "wobble", Status: pgtype.Present},
|
||||
{String: "wubble", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{
|
||||
{LowerBound: 1, Length: 2},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 3}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringSliceDim4,
|
||||
expected: [][][][]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringArrayDim2,
|
||||
expected: [2][1]string{{"foo"}, {"bar"}},
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{
|
||||
{String: "foo", Status: pgtype.Present},
|
||||
{String: "bar", Status: pgtype.Present},
|
||||
{String: "baz", Status: pgtype.Present},
|
||||
{String: "wibble", Status: pgtype.Present},
|
||||
{String: "wobble", Status: pgtype.Present},
|
||||
{String: "wubble", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{
|
||||
{LowerBound: 1, Length: 2},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 1},
|
||||
{LowerBound: 1, Length: 3}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringArrayDim4,
|
||||
expected: [2][1][1][3]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
||||
},
|
||||
}
|
||||
|
||||
for i, tt := range simpleTests {
|
||||
@@ -140,6 +244,27 @@ func TestEnumArrayArrayAssignTo(t *testing.T) {
|
||||
},
|
||||
dst: &stringSlice,
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}, {LowerBound: 1, Length: 2}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringArrayDim2,
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}, {LowerBound: 1, Length: 2}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringSlice,
|
||||
},
|
||||
{
|
||||
src: pgtype.EnumArray{
|
||||
Elements: []pgtype.GenericText{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
||||
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
||||
Status: pgtype.Present},
|
||||
dst: &stringArrayDim4,
|
||||
},
|
||||
}
|
||||
|
||||
for i, tt := range errorTests {
|
||||
|
||||
Reference in New Issue
Block a user