Fix: do not silently ignore assign NULL to *string
AssignTo can only assign NULL to a **string. Previous code tried to assign nil to a *string, which did nothing. Correct behavior is to detect this as an error.
This commit is contained in:
+11
-5
@@ -72,14 +72,20 @@ func (dst *JSON) Get() interface{} {
|
||||
func (src *JSON) AssignTo(dst interface{}) error {
|
||||
switch v := dst.(type) {
|
||||
case *string:
|
||||
if src.Status != Present {
|
||||
v = nil
|
||||
} else {
|
||||
if src.Status == Present {
|
||||
*v = string(src.Bytes)
|
||||
} else {
|
||||
return errors.Errorf("cannot assign non-present status to %T", dst)
|
||||
}
|
||||
case **string:
|
||||
*v = new(string)
|
||||
return src.AssignTo(*v)
|
||||
if src.Status == Present {
|
||||
s := string(src.Bytes)
|
||||
*v = &s
|
||||
return nil
|
||||
} else {
|
||||
*v = nil
|
||||
return nil
|
||||
}
|
||||
case *[]byte:
|
||||
if src.Status != Present {
|
||||
*v = nil
|
||||
|
||||
Reference in New Issue
Block a user