From 21656fbd17a5f7183cf8ea9c893022df0a38142b Mon Sep 17 00:00:00 2001 From: Jack Christensen Date: Sat, 17 Nov 2018 20:24:22 -0600 Subject: [PATCH] Add context / cancel ideas --- v4.md | 1 + 1 file changed, 1 insertion(+) diff --git a/v4.md b/v4.md index a21393ee..a941a1bb 100644 --- a/v4.md +++ b/v4.md @@ -19,6 +19,7 @@ Potential Changes: * Decouple various logical layers of PostgreSQL connection such that an advanced user can choose what layer to work at and pgx still handles the lower level details. e.g Normal high level query level, PostgreSQL wire protocol message level, or wire byte level. * Change prepared statement usage from using name as SQL text to specifically calling prepared statement (more like database/sql). * Remove stdlib hack for RegisterDriverConfig now that database/sql supports better way +* Consider how to simplify context.Context and query cancellation support (or even remove). This logic is very complex and error prone. Perhaps connections should simply be killed on a cancelled context rather than trying to recover. Separating PostgreSQL query cancellation from context might simplify them both. Also consider that PG queries can be cancelled and connections can be terminated via SQL functions from another connection. Minor Potential Changes: