2
0

pgtype.Encode(Binary|Text) do not write length

To aid in composability, these methods no longer write their own length. This
is especially useful for text formatted arrays and may be useful for future
database/sql compatibility. It also makes the code a little simpler as the
types no longer have to compute their own size.

Along with this, these methods cannot encode NULL. They now return a boolean
if they are NULL. This also benefits text array encoding as numeric arrays
require NULL to be exactly `NULL` while string arrays require NULL to be
`"NULL"`.
This commit is contained in:
Jack Christensen
2017-03-11 12:32:33 -06:00
parent 6c26c3a4a3
commit 1f3e484ca1
38 changed files with 1271 additions and 1319 deletions
+16 -22
View File
@@ -5,8 +5,6 @@ import (
"io"
"reflect"
"strconv"
"github.com/jackc/pgx/pgio"
)
type Bool struct {
@@ -100,14 +98,12 @@ func (dst *Bool) DecodeBinary(src []byte) error {
return nil
}
func (src Bool) EncodeText(w io.Writer) error {
if done, err := encodeNotPresent(w, src.Status); done {
return err
}
_, err := pgio.WriteInt32(w, 1)
if err != nil {
return nil
func (src Bool) EncodeText(w io.Writer) (bool, error) {
switch src.Status {
case Null:
return true, nil
case Undefined:
return false, errUndefined
}
var buf []byte
@@ -117,18 +113,16 @@ func (src Bool) EncodeText(w io.Writer) error {
buf = []byte{'f'}
}
_, err = w.Write(buf)
return err
_, err := w.Write(buf)
return false, err
}
func (src Bool) EncodeBinary(w io.Writer) error {
if done, err := encodeNotPresent(w, src.Status); done {
return err
}
_, err := pgio.WriteInt32(w, 1)
if err != nil {
return nil
func (src Bool) EncodeBinary(w io.Writer) (bool, error) {
switch src.Status {
case Null:
return true, nil
case Undefined:
return false, errUndefined
}
var buf []byte
@@ -138,6 +132,6 @@ func (src Bool) EncodeBinary(w io.Writer) error {
buf = []byte{0}
}
_, err = w.Write(buf)
return err
_, err := w.Write(buf)
return false, err
}