gopkg/pgx
2
0
Fork 0
Code Activity

Fix connect when receiving NoticeResponse

Browse Source 
refs #102
This commit is contained in:
Jack Christensen
2022-01-20 16:40:44 -06:00
parent 109c4c2d95
commit 05d532b5df
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pgconn.go
+1 -1
View File
@@ -335,7 +335,7 @@ func connect(ctx context.Context, config *Config, fallbackConfig *FallbackConfig
} }
} }
return pgConn, nil return pgConn, nil
case *pgproto3.ParameterStatus: case *pgproto3.ParameterStatus, *pgproto3.NoticeResponse:
// handled by ReceiveMessage // handled by ReceiveMessage
case *pgproto3.ErrorResponse: case *pgproto3.ErrorResponse:
pgConn.conn.Close() pgConn.conn.Close()
pgconn_test.go
+6 -1
View File
@@ -1298,6 +1298,7 @@ func TestConnOnNotice(t *testing.T) {
config.OnNotice = func(c *pgconn.PgConn, notice *pgconn.Notice) { config.OnNotice = func(c *pgconn.PgConn, notice *pgconn.Notice) {
msg = notice.Message msg = notice.Message
} }
config.RuntimeParams["client_min_messages"] = "notice" // Ensure we only get the message we expect.
pgConn, err := pgconn.ConnectConfig(context.Background(), config) pgConn, err := pgconn.ConnectConfig(context.Background(), config)
require.NoError(t, err) require.NoError(t, err)
@@ -1954,7 +1955,11 @@ func TestConnSendBytesAndReceiveMessage(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), time.Second*5) ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
defer cancel() defer cancel()
pgConn, err := pgconn.Connect(ctx, os.Getenv("PGX_TEST_CONN_STRING")) config, err := pgconn.ParseConfig(os.Getenv("PGX_TEST_CONN_STRING"))
require.NoError(t, err)
config.RuntimeParams["client_min_messages"] = "notice" // Ensure we only get the messages we expect.
pgConn, err := pgconn.ConnectConfig(context.Background(), config)
require.NoError(t, err) require.NoError(t, err)
defer closeConn(t, pgConn) defer closeConn(t, pgConn)