2
0

Use bytes.Equal rather than bytes.Compare ==/!= 0

As recommended by go-staticcheck, but also might be a bit more efficient
for the compiler to implement, since we don't care about which slice of
bytes is greater than the other one.
This commit is contained in:
Dan McGee
2023-07-07 16:15:57 -05:00
committed by Jack Christensen
parent cd46cdd450
commit 0328d314ea
12 changed files with 19 additions and 19 deletions
+2 -2
View File
@@ -547,7 +547,7 @@ func TestConnQueryJSONIntoByteSlice(t *testing.T) {
t.Errorf("Unexpected failure: %v (sql -> %v)", err, sql)
}
if bytes.Compare(actual, expected) != 0 {
if !bytes.Equal(actual, expected) {
t.Errorf(`Expected "%v", got "%v" (sql -> %v)`, string(expected), string(actual), sql)
}
@@ -579,7 +579,7 @@ func TestConnExecInsertByteSliceIntoJSON(t *testing.T) {
err = db.QueryRow(`select body from docs`).Scan(&actual)
require.NoError(t, err)
if bytes.Compare(actual, expected) != 0 {
if !bytes.Equal(actual, expected) {
t.Errorf(`Expected "%v", got "%v"`, string(expected), string(actual))
}