2
0

Use bytes.Equal rather than bytes.Compare ==/!= 0

As recommended by go-staticcheck, but also might be a bit more efficient
for the compiler to implement, since we don't care about which slice of
bytes is greater than the other one.
This commit is contained in:
Dan McGee
2023-07-07 16:15:57 -05:00
committed by Jack Christensen
parent cd46cdd450
commit 0328d314ea
12 changed files with 19 additions and 19 deletions
+3 -3
View File
@@ -17,7 +17,7 @@ func TestChunkReaderNextDoesNotReadIfAlreadyBuffered(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if bytes.Compare(n1, src[0:2]) != 0 {
if !bytes.Equal(n1, src[0:2]) {
t.Fatalf("Expected read bytes to be %v, but they were %v", src[0:2], n1)
}
@@ -25,11 +25,11 @@ func TestChunkReaderNextDoesNotReadIfAlreadyBuffered(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if bytes.Compare(n2, src[2:4]) != 0 {
if !bytes.Equal(n2, src[2:4]) {
t.Fatalf("Expected read bytes to be %v, but they were %v", src[2:4], n2)
}
if bytes.Compare((*r.buf)[:len(src)], src) != 0 {
if !bytes.Equal((*r.buf)[:len(src)], src) {
t.Fatalf("Expected r.buf to be %v, but it was %v", src, r.buf)
}