responses to code review

- field rename to be more properly generic
 - drop rewrite of main.main
This commit is contained in:
Dave Clendenan
2016-12-06 12:53:21 -08:00
parent d8fd23467c
commit 88dd8df1f8
7 changed files with 50 additions and 49 deletions
+9 -9
View File
@@ -9,10 +9,10 @@ type fieldKey string
type FieldMap map[fieldKey]string
const (
FieldKeyMsg = "msg"
FieldKeyLevel = "level"
FieldKeyTime = "time"
FieldKeyCaller = "method"
FieldKeyMsg = "msg"
FieldKeyLevel = "level"
FieldKeyTime = "time"
FieldKeyFunc = "func"
)
func (f FieldMap) resolve(key fieldKey) string {
@@ -34,10 +34,10 @@ type JSONFormatter struct {
// As an example:
// formatter := &JSONFormatter{
// FieldMap: FieldMap{
// FieldKeyTime: "@timestamp",
// FieldKeyLevel: "@level",
// FieldKeyMsg: "@message",
// FieldKeyCaller: "@caller",
// FieldKeyTime: "@timestamp",
// FieldKeyLevel: "@level",
// FieldKeyMsg: "@message",
// FieldKeyFunc: "@caller",
// },
// }
FieldMap FieldMap
@@ -69,7 +69,7 @@ func (f *JSONFormatter) Format(entry *Entry) ([]byte, error) {
data[f.FieldMap.resolve(FieldKeyMsg)] = entry.Message
data[f.FieldMap.resolve(FieldKeyLevel)] = entry.Level.String()
if entry.HasCaller() {
data[f.FieldMap.resolve(FieldKeyCaller)] = entry.Caller
data[f.FieldMap.resolve(FieldKeyFunc)] = entry.Caller
}
serialized, err := json.Marshal(data)
if err != nil {