gopkg/logrus
2
0
Fork 0
Code Pull Requests Activity

Merge pull request #563 from meatballhat/unquote-more-chars

Browse Source 
Allow more chars in unquoted text formatter output
This commit is contained in:
Damien Mathieu
2017-07-12 13:55:30 +02:00
committed by GitHub
parent 398dd088c2 5d67428857
commit 6f87387fae
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
text_formatter.go
+1 -1
View File
@@ -153,7 +153,7 @@ func (f *TextFormatter) needsQuoting(text string) bool {
if !((ch >= 'a' && ch <= 'z') || if !((ch >= 'a' && ch <= 'z') ||
(ch >= 'A' && ch <= 'Z') || (ch >= 'A' && ch <= 'Z') ||
(ch >= '0' && ch <= '9') || (ch >= '0' && ch <= '9') ||
ch == '-' || ch == '.') { ch == '-' || ch == '.' || ch == '_' || ch == '/' || ch == '@' || ch == '^' || ch == '+') {
return true return true
} }
} }
text_formatter_test.go
+13 -2
View File
@@ -28,7 +28,13 @@ func TestQuoting(t *testing.T) {
checkQuoting(false, "abcd") checkQuoting(false, "abcd")
checkQuoting(false, "v1.0") checkQuoting(false, "v1.0")
checkQuoting(false, "1234567890") checkQuoting(false, "1234567890")
checkQuoting(true, "/foobar") checkQuoting(false, "/foobar")
checkQuoting(false, "foo_bar")
checkQuoting(false, "foo@bar")
checkQuoting(false, "foobar^")
checkQuoting(false, "+/-_^@f.oobar")
checkQuoting(true, "foobar$")
checkQuoting(true, "&foobar")
checkQuoting(true, "x y") checkQuoting(true, "x y")
checkQuoting(true, "x,y") checkQuoting(true, "x,y")
checkQuoting(false, errors.New("invalid")) checkQuoting(false, errors.New("invalid"))
@@ -38,7 +44,12 @@ func TestQuoting(t *testing.T) {
tf.QuoteCharacter = "`" tf.QuoteCharacter = "`"
checkQuoting(false, "") checkQuoting(false, "")
checkQuoting(false, "abcd") checkQuoting(false, "abcd")
checkQuoting(true, "/foobar") checkQuoting(false, "/foobar")
checkQuoting(false, "foo_bar")
checkQuoting(false, "foo@bar")
checkQuoting(false, "foobar^")
checkQuoting(true, "foobar$")
checkQuoting(true, "&foobar")
checkQuoting(true, errors.New("invalid argument")) checkQuoting(true, errors.New("invalid argument"))
// Test for multi-character quotes. // Test for multi-character quotes.