Abhinav Gupta
a86bda490b
The golangci-lint being used was quite dated. This change upgrades to the latest version. Adds and updates exclusions based on new failures. Note on revive: I've included an opt-out for unused parameters for revive because turning `newThing(required bool)` to `newThing(_ bool)` is a loss of useful information. The changes to the Go files are to fix the following issues: ``` camelcase.go:16: File is not `gofmt`-ed with `-s` (gofmt) config_test.go:50:18: directive `//nolint: gosec` is unused for linter "gosec" (nolintlint) defaults_test.go:28:25: G601: Implicit memory aliasing in for loop. (gosec) doc.go:5: File is not `gofmt`-ed with `-s` (gofmt) kong.go:446:18: directive `//nolint: gosec` is unused for linter "gosec" (nolintlint) kong_test.go:503:20: G601: Implicit memory aliasing in for loop. (gosec) model.go:493:10: composites: reflect.ValueError struct literal uses unkeyed fields (govet) scanner.go:112: File is not `gofmt`-ed with `-s` (gofmt) ``` And to address broken nolint directives reported as follows by golangci-lint. ``` [.. skipped .. ] tag.go:65:1: directive `// nolint:gocyclo` should be written without leading space as `//nolint:gocyclo` (nolintlint) tag.go:206:51: directive `// nolint: gocyclo` should be written without leading space as `//nolint: gocyclo` (nolintlint) util_test.go:23:43: directive `// nolint: errcheck` should be written without leading space as `//nolint: errcheck` (nolintlint) util_test.go:51:22: directive `// nolint: errcheck` should be written without leading space as `//nolint: errcheck` (nolintlint) ```
58 lines
1.7 KiB
Go
58 lines
1.7 KiB
Go
package kong
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"reflect"
|
|
)
|
|
|
|
// ConfigFlag uses the configured (via kong.Configuration(loader)) configuration loader to load configuration
|
|
// from a file specified by a flag.
|
|
//
|
|
// Use this as a flag value to support loading of custom configuration via a flag.
|
|
type ConfigFlag string
|
|
|
|
// BeforeResolve adds a resolver.
|
|
func (c ConfigFlag) BeforeResolve(kong *Kong, ctx *Context, trace *Path) error {
|
|
if kong.loader == nil {
|
|
return fmt.Errorf("kong must be configured with kong.Configuration(...)")
|
|
}
|
|
path := string(ctx.FlagValue(trace.Flag).(ConfigFlag)) //nolint
|
|
resolver, err := kong.LoadConfig(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
ctx.AddResolver(resolver)
|
|
return nil
|
|
}
|
|
|
|
// VersionFlag is a flag type that can be used to display a version number, stored in the "version" variable.
|
|
type VersionFlag bool
|
|
|
|
// BeforeReset writes the version variable and terminates with a 0 exit status.
|
|
func (v VersionFlag) BeforeReset(app *Kong, vars Vars) error {
|
|
fmt.Fprintln(app.Stdout, vars["version"])
|
|
app.Exit(0)
|
|
return nil
|
|
}
|
|
|
|
// ChangeDirFlag changes the current working directory to a path specified by a flag
|
|
// early in the parsing process, changing how other flags resolve relative paths.
|
|
//
|
|
// Use this flag to provide a "git -C" like functionality.
|
|
//
|
|
// It is not compatible with custom named decoders, e.g., existingdir.
|
|
type ChangeDirFlag string
|
|
|
|
// Decode is used to create a side effect of changing the current working directory.
|
|
func (c ChangeDirFlag) Decode(ctx *DecodeContext) error {
|
|
var path string
|
|
err := ctx.Scan.PopValueInto("string", &path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
path = ExpandPath(path)
|
|
ctx.Value.Target.Set(reflect.ValueOf(ChangeDirFlag(path)))
|
|
return os.Chdir(path)
|
|
}
|