Abhinav Gupta
a86bda490b
The golangci-lint being used was quite dated. This change upgrades to the latest version. Adds and updates exclusions based on new failures. Note on revive: I've included an opt-out for unused parameters for revive because turning `newThing(required bool)` to `newThing(_ bool)` is a loss of useful information. The changes to the Go files are to fix the following issues: ``` camelcase.go:16: File is not `gofmt`-ed with `-s` (gofmt) config_test.go:50:18: directive `//nolint: gosec` is unused for linter "gosec" (nolintlint) defaults_test.go:28:25: G601: Implicit memory aliasing in for loop. (gosec) doc.go:5: File is not `gofmt`-ed with `-s` (gofmt) kong.go:446:18: directive `//nolint: gosec` is unused for linter "gosec" (nolintlint) kong_test.go:503:20: G601: Implicit memory aliasing in for loop. (gosec) model.go:493:10: composites: reflect.ValueError struct literal uses unkeyed fields (govet) scanner.go:112: File is not `gofmt`-ed with `-s` (gofmt) ``` And to address broken nolint directives reported as follows by golangci-lint. ``` [.. skipped .. ] tag.go:65:1: directive `// nolint:gocyclo` should be written without leading space as `//nolint:gocyclo` (nolintlint) tag.go:206:51: directive `// nolint: gocyclo` should be written without leading space as `//nolint: gocyclo` (nolintlint) util_test.go:23:43: directive `// nolint: errcheck` should be written without leading space as `//nolint: errcheck` (nolintlint) util_test.go:51:22: directive `// nolint: errcheck` should be written without leading space as `//nolint: errcheck` (nolintlint) ```
91 lines
2.8 KiB
Go
91 lines
2.8 KiB
Go
package kong
|
|
|
|
// NOTE: This code is from https://github.com/fatih/camelcase. MIT license.
|
|
|
|
import (
|
|
"unicode"
|
|
"unicode/utf8"
|
|
)
|
|
|
|
// Split splits the camelcase word and returns a list of words. It also
|
|
// supports digits. Both lower camel case and upper camel case are supported.
|
|
// For more info please check: http://en.wikipedia.org/wiki/CamelCase
|
|
//
|
|
// Examples
|
|
//
|
|
// "" => [""]
|
|
// "lowercase" => ["lowercase"]
|
|
// "Class" => ["Class"]
|
|
// "MyClass" => ["My", "Class"]
|
|
// "MyC" => ["My", "C"]
|
|
// "HTML" => ["HTML"]
|
|
// "PDFLoader" => ["PDF", "Loader"]
|
|
// "AString" => ["A", "String"]
|
|
// "SimpleXMLParser" => ["Simple", "XML", "Parser"]
|
|
// "vimRPCPlugin" => ["vim", "RPC", "Plugin"]
|
|
// "GL11Version" => ["GL", "11", "Version"]
|
|
// "99Bottles" => ["99", "Bottles"]
|
|
// "May5" => ["May", "5"]
|
|
// "BFG9000" => ["BFG", "9000"]
|
|
// "BöseÜberraschung" => ["Böse", "Überraschung"]
|
|
// "Two spaces" => ["Two", " ", "spaces"]
|
|
// "BadUTF8\xe2\xe2\xa1" => ["BadUTF8\xe2\xe2\xa1"]
|
|
//
|
|
// Splitting rules
|
|
//
|
|
// 1. If string is not valid UTF-8, return it without splitting as
|
|
// single item array.
|
|
// 2. Assign all unicode characters into one of 4 sets: lower case
|
|
// letters, upper case letters, numbers, and all other characters.
|
|
// 3. Iterate through characters of string, introducing splits
|
|
// between adjacent characters that belong to different sets.
|
|
// 4. Iterate through array of split strings, and if a given string
|
|
// is upper case:
|
|
// if subsequent string is lower case:
|
|
// move last character of upper case string to beginning of
|
|
// lower case string
|
|
func camelCase(src string) (entries []string) {
|
|
// don't split invalid utf8
|
|
if !utf8.ValidString(src) {
|
|
return []string{src}
|
|
}
|
|
entries = []string{}
|
|
var runes [][]rune
|
|
lastClass := 0
|
|
// split into fields based on class of unicode character
|
|
for _, r := range src {
|
|
var class int
|
|
switch {
|
|
case unicode.IsLower(r):
|
|
class = 1
|
|
case unicode.IsUpper(r):
|
|
class = 2
|
|
case unicode.IsDigit(r):
|
|
class = 3
|
|
default:
|
|
class = 4
|
|
}
|
|
if class == lastClass {
|
|
runes[len(runes)-1] = append(runes[len(runes)-1], r)
|
|
} else {
|
|
runes = append(runes, []rune{r})
|
|
}
|
|
lastClass = class
|
|
}
|
|
// handle upper case -> lower case sequences, e.g.
|
|
// "PDFL", "oader" -> "PDF", "Loader"
|
|
for i := 0; i < len(runes)-1; i++ {
|
|
if unicode.IsUpper(runes[i][0]) && unicode.IsLower(runes[i+1][0]) {
|
|
runes[i+1] = append([]rune{runes[i][len(runes[i])-1]}, runes[i+1]...)
|
|
runes[i] = runes[i][:len(runes[i])-1]
|
|
}
|
|
}
|
|
// construct []string from results
|
|
for _, s := range runes {
|
|
if len(s) > 0 {
|
|
entries = append(entries, string(s))
|
|
}
|
|
}
|
|
return entries
|
|
}
|