Fix sep:"none" and mapsep:"none"
According to the README.md, a value of `"none"` for the `sep` tag (for slices) and `mapsep` (for maps) is meant to disable the separator that would allow multiple entries to be added from a single argument. However, using `"none"` just set the separator to the rune `'n'`. Fix the parsing of the tag, and also update `SplitEscaped` to not split with a separator of `-1`. Add a new test for the new cases.
This commit is contained in:
committed by
Alec Thomas
parent
b11ebc500b
commit
b89354adb0
@@ -130,6 +130,7 @@ func TestDurationMapper(t *testing.T) {
|
||||
func TestSplitEscaped(t *testing.T) {
|
||||
require.Equal(t, []string{"a", "b"}, kong.SplitEscaped("a,b", ','))
|
||||
require.Equal(t, []string{"a,b", "c"}, kong.SplitEscaped(`a\,b,c`, ','))
|
||||
require.Equal(t, []string{"a,b,c"}, kong.SplitEscaped(`a,b,c`, -1))
|
||||
}
|
||||
|
||||
func TestJoinEscaped(t *testing.T) {
|
||||
@@ -172,6 +173,18 @@ func TestMapWithDifferentSeparator(t *testing.T) {
|
||||
require.Equal(t, map[string]string{"a": "b", "c": "d"}, cli.Value)
|
||||
}
|
||||
|
||||
func TestMapWithNoSeparator(t *testing.T) {
|
||||
var cli struct {
|
||||
Slice []string `sep:"none"`
|
||||
Value map[string]string `mapsep:"none"`
|
||||
}
|
||||
k := mustNew(t, &cli)
|
||||
_, err := k.Parse([]string{"--slice=a,n,c", "--value=a=b;n=d"})
|
||||
require.NoError(t, err)
|
||||
require.Equal(t, []string{"a,n,c"}, cli.Slice)
|
||||
require.Equal(t, map[string]string{"a": "b;n=d"}, cli.Value)
|
||||
}
|
||||
|
||||
func TestURLMapper(t *testing.T) {
|
||||
var cli struct {
|
||||
URL *url.URL `arg:""`
|
||||
|
||||
Reference in New Issue
Block a user